From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chuong Ngo <cngo.github@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list.
Date: Tue, 22 Oct 2013 11:39:58 +0300 [thread overview]
Message-ID: <20131022083958.GB5871@mwanda> (raw)
In-Reply-To: <1382338644-7984-1-git-send-email-cngo.github@gmail.com>
On Mon, Oct 21, 2013 at 02:57:24AM -0400, Chuong Ngo wrote:
> Removed a debug message as outlined in the TODO list.
The Signed-off-by line is missing. Run checkpatch.pl over your patch.
Hopefully it should warn you to remove the curly braced because they
are not needed any more.
Otherwise the patch is ok. Please fix the two issues and resend.
regards,
dan carpenter
prev parent reply other threads:[~2013-10-22 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 6:57 [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list Chuong Ngo
2013-10-22 8:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022083958.GB5871@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cngo.github@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox