public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: perf test failing for "sample parsing"
Date: Tue, 22 Oct 2013 15:35:39 -0300	[thread overview]
Message-ID: <20131022183539.GA18057@ghostprotocols.net> (raw)

Andi,

	I should've caught this when processing those patches, but
please consider running 'perf test' before and after your future patch
kits :-)

[root@sandy ~]# perf test 22
22: Test sample parsing                                    : FAILED!
[root@sandy ~]# perf test -v 22
22: Test sample parsing                                    :
--- start ---
sample format has changed - test needs updating
---- end ----
Test sample parsing: FAILED!
[root@sandy ~]#

	So I bisected it down to:

  commit fdfbbd07e91f8fe387140776f3fd94605f0c89e5
  Author: Andi Kleen <ak@linux.intel.com>
  Date:   Fri Sep 20 07:40:39 2013 -0700

      perf: Add generic transaction flags
    
      Add a generic qualifier for transaction events, as a new sample
      type that returns a flag word. This is particularly useful
      for qualifying aborts: to distinguish aborts which happen
      due to asynchronous events (like conflicts caused by another
      CPU) versus instructions that lead to an abort.
 
   extern void perf_output_sample(struct perf_output_handle *handle,
  diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
  index 009a655..da48837 100644
  --- a/include/uapi/linux/perf_event.h
  +++ b/include/uapi/linux/perf_event.h
  @@ -136,8 +136,9 @@ enum perf_event_sample_format {
   	PERF_SAMPLE_WEIGHT			= 1U << 14,
   	PERF_SAMPLE_DATA_SRC			= 1U << 15,
   	PERF_SAMPLE_IDENTIFIER			= 1U << 16,
  +	PERF_SAMPLE_TRANSACTION			= 1U << 17,
   
  -	PERF_SAMPLE_MAX = 1U << 17,		/* non-ABI */
  +	PERF_SAMPLE_MAX = 1U << 18,		/* non-ABI */

--------------------------------------------------------------------------------------


	So I looked at tools/perf/tests/builtin-test.c for the "Test sample parsing"
string and found the test__sample_parsing function, and fixed it there,
patches sent to my perf/core branch.

	This one was harmless, but there were problems that were caught
by running 'perf test' while writing patchkits,

Thanks,

- Arnaldo

             reply	other threads:[~2013-10-22 18:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 18:35 Arnaldo Carvalho de Melo [this message]
2013-10-23  8:40 ` perf test failing for "sample parsing" Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131022183539.GA18057@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox