From: Dave Chinner <dchinner@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Colin Cross <ccross@android.com>,
Android Kernel Team <kernel-team@android.com>,
Glauber Costa <glommer@openvz.org>
Subject: Re: [PATCH] staging: ashmem: Fix ASHMEM_PURGE_ALL_CACHES return value
Date: Wed, 23 Oct 2013 07:48:01 +1100 [thread overview]
Message-ID: <20131022204801.GC1969@devil.localdomain> (raw)
In-Reply-To: <1382374687-4831-1-git-send-email-john.stultz@linaro.org>
On Mon, Oct 21, 2013 at 09:58:07AM -0700, John Stultz wrote:
> Hopefully this isn't too late for 3.12.
>
> In commit 7dc19d5aff (convert shrinkers to new count/scan API)
> the return value to PURGE_ALL_CACHES was dropped, causing -EPERM
> to always be returned.
>
> This patch re-adds the ret assignment, setting it to the the
> ashmem_shrink_count(), which is the lru_count.
Looks sane.
Acked-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
dchinner@redhat.com
prev parent reply other threads:[~2013-10-22 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 16:58 [PATCH] staging: ashmem: Fix ASHMEM_PURGE_ALL_CACHES return value John Stultz
2013-10-22 20:48 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022204801.GC1969@devil.localdomain \
--to=dchinner@redhat.com \
--cc=ccross@android.com \
--cc=glommer@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox