From: Frederic Weisbecker <fweisbec@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>,
khilman@linaro.org, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: context_tracking: use extern function instead of static inline function for user_enter/exit()
Date: Wed, 23 Oct 2013 12:11:49 +0100 [thread overview]
Message-ID: <20131023111147.GB2502@localhost.localdomain> (raw)
In-Reply-To: <5267A72B.7060808@asianux.com>
On Wed, Oct 23, 2013 at 06:38:35PM +0800, Chen Gang wrote:
> The related assemble code can not find the static inline function. The
> related commit "ad65782 context_tracking: Optimize main APIs off case
> with static key" causes this issue.
>
> The related error (for arm, with allmodconfig):
>
> LD init/built-in.o
> arch/arm/kernel/built-in.o: In function `ret_fast_syscall':
> arch/arm/kernel/entry-common.S:42: undefined reference to `user_enter'
> arch/arm/kernel/built-in.o: In function `no_work_pending':
> arch/arm/kernel/entry-common.S:77: undefined reference to `user_enter'
> arch/arm/kernel/built-in.o: In function `vector_swi':
> arch/arm/kernel/entry-common.S:376: undefined reference to `user_exit'
> arch/arm/kernel/built-in.o: In function `__dabt_usr':
> arch/arm/kernel/entry-armv.S:365: undefined reference to `user_exit'
> arch/arm/kernel/built-in.o: In function `__irq_usr':
> arch/arm/kernel/entry-armv.S:375: undefined reference to `user_exit'
> arch/arm/kernel/built-in.o: In function `__und_usr':
> arch/arm/kernel/entry-armv.S:388: undefined reference to `user_exit'
> arch/arm/kernel/built-in.o: In function `__pabt_usr':
> arch/arm/kernel/entry-armv.S:662: undefined reference to `user_exit'
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Doesn't 0c06a5d4b13cd66c833805a0d1db76b977944aac
("arm: Fix build error with context tracking calls") fix the issue for you?
Or may be it's another problem I missed?
Thanks.
next prev parent reply other threads:[~2013-10-23 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 10:38 [PATCH] kernel: context_tracking: use extern function instead of static inline function for user_enter/exit() Chen Gang
2013-10-23 10:47 ` Steven Rostedt
2013-10-23 11:01 ` Chen Gang
2013-10-23 11:15 ` Steven Rostedt
2013-10-23 11:31 ` Chen Gang
2013-10-23 11:11 ` Frederic Weisbecker [this message]
2013-10-23 11:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023111147.GB2502@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gang.chen@asianux.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox