From: Jens Axboe <axboe@kernel.dk>
To: Kent Overstreet <kmo@daterainc.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()
Date: Thu, 24 Oct 2013 13:04:06 +0100 [thread overview]
Message-ID: <20131024120406.GY14598@kernel.dk> (raw)
In-Reply-To: <1382481353-4300-1-git-send-email-kmo@daterainc.com>
On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <kmo@daterainc.com>
> Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
> ---
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>
> if (bio->bi_rw & REQ_FLUSH) {
> /* Also need to send a flush to the backing device */
> - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
> dc->disk.bio_split);
>
> flush->bi_rw = WRITE_FLUSH;
Woops... Added.
--
Jens Axboe
prev parent reply other threads:[~2013-10-24 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 22:35 [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() Kent Overstreet
2013-10-24 12:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024120406.GY14598@kernel.dk \
--to=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox