From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf: Fix library detection when building without libelf
Date: Thu, 24 Oct 2013 17:13:49 -0300 [thread overview]
Message-ID: <20131024201349.GG4998@ghostprotocols.net> (raw)
In-Reply-To: <1382583069-26121-1-git-send-email-patrick@parcs.ath.cx>
Em Wed, Oct 23, 2013 at 10:51:09PM -0400, Patrick Palka escreveu:
> When I attempt to build perf on a system with slang but without libelf,
> 'make' would wrongly complain that the slang library could not be found.
>
> It turns out that this was happening because we are not filtering -lelf
> from EXTLIBS early enough. As a result, the library test for slang
> (ditto for gtk, libaudit, etc) erroneously passes -lelf to try-cc, which
> of course fails on a system without libelf.
>
> This patch makes the filtering of -lelf from EXTLIBS occur right after
> testing for libelf support, so that the subsequent library tests will
> not erroneously pass -lelf to try-cc when building without libelf
> support.
Can you please check with the perf/core branch in my tree or Ingo's?
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
or Ingo's:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
The feature detection was reworked and perhaps it is fixed there.
- Arnaldo
next prev parent reply other threads:[~2013-10-24 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 2:51 [PATCH] perf: Fix library detection when building without libelf Patrick Palka
2013-10-24 20:13 ` Arnaldo Carvalho de Melo [this message]
2013-10-24 20:36 ` Patrick Palka
2013-10-24 20:46 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024201349.GG4998@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick@parcs.ath.cx \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox