From: Felipe Balbi <balbi@ti.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arjan van de Ven <arjan@linux.intel.com>,
<linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] device: Make dev_WARN/dev_WARN_ONCE print device as well as driver name
Date: Thu, 24 Oct 2013 21:29:41 -0500 [thread overview]
Message-ID: <20131025022941.GA2261@gimli> (raw)
In-Reply-To: <20131024214233.12347.95711.stgit@bhelgaas-glaptop.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Thu, Oct 24, 2013 at 03:42:33PM -0600, Bjorn Helgaas wrote:
> dev_WARN() and dev_WARN_ONCE() are annoying because (1) they include
> only the driver name, not the device name, and (2) they print a spurious
> newline in the middle. This results in messages like this that are less
> useful than they should be:
>
> [ 40.094995] Device pcieport
> disabling already-disabled device
>
> This patch makes them work more like dev_printk().
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Pretty cool, much nicer output indeed :-)
Reviewed-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-25 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:42 [PATCH] device: Make dev_WARN/dev_WARN_ONCE print device as well as driver name Bjorn Helgaas
2013-10-25 2:29 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025022941.GA2261@gimli \
--to=balbi@ti.com \
--cc=arjan@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox