From: Jens Axboe <axboe@kernel.dk>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 01/11] Export __smp_call_function_single()
Date: Fri, 25 Oct 2013 11:44:35 +0100 [thread overview]
Message-ID: <20131025104435.GC6285@kernel.dk> (raw)
In-Reply-To: <20131025102154.GB3481@gmail.com>
On Fri, Oct 25 2013, Ingo Molnar wrote:
>
> * Jens Axboe <axboe@kernel.dk> wrote:
>
> > The blk-mq core and the blk-mq null driver uses it.
> >
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > ---
> > kernel/smp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/smp.c b/kernel/smp.c
> > index 0564571..9de461e 100644
> > --- a/kernel/smp.c
> > +++ b/kernel/smp.c
> > @@ -340,6 +340,7 @@ void __smp_call_function_single(int cpu, struct call_single_data *csd,
> > }
> > put_cpu();
> > }
> > +EXPORT_SYMBOL(__smp_call_function_single);
>
> I agree with exporting it to in-kernel users, but I'd prefer a _GPL
> export for newly exported symbols that are for in-kernel use.
Agree, it should be _GPL. I will update the patch. Can I add your
acked-by?
--
Jens Axboe
next prev parent reply other threads:[~2013-10-25 10:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 9:25 Jens Axboe
2013-10-24 9:25 ` [PATCH 01/11] Export __smp_call_function_single() Jens Axboe
2013-10-24 9:50 ` Christoph Hellwig
2013-10-24 10:16 ` Jens Axboe
2013-10-24 12:50 ` Christoph Hellwig
2013-10-25 10:21 ` Ingo Molnar
2013-10-25 10:44 ` Jens Axboe [this message]
2013-10-25 10:45 ` Ingo Molnar
2013-10-24 9:25 ` [PATCH 02/11] smp: don't warn about csd->flags having CSD_FLAG_LOCK cleared for !wait Jens Axboe
2013-10-24 9:39 ` Christoph Hellwig
2013-10-24 9:25 ` [PATCH 03/11] block: make rq->cmd_flags be 64-bit Jens Axboe
2013-10-24 9:40 ` Christoph Hellwig
2013-10-24 9:25 ` [PATCH 04/11] block: remove request ref_count Jens Axboe
2013-10-24 9:25 ` [PATCH 05/11] direct-io: only inc/dec inode->i_dio_count for file systems Jens Axboe
2013-10-24 9:46 ` Jens Axboe
2013-10-24 9:47 ` Christoph Hellwig
2013-10-24 9:49 ` Jens Axboe
2015-02-05 16:54 ` Mike Snitzer
2013-10-24 9:25 ` [PATCH 06/11] percpu_counter: make APIs irq safe Jens Axboe
2013-10-24 9:26 ` [PATCH 07/11] percpu_ida: make percpu_ida percpu size/batch configurable Jens Axboe
2013-10-24 9:26 ` [PATCH 08/11] percpu_ida: add percpu_ida_for_each_free Jens Axboe
2013-10-24 9:26 ` [PATCH 09/11] percpu_ida: add an API to return free tags Jens Axboe
2013-10-24 9:26 ` [PATCH 10/11] blk-mq: new multi-queue block IO queueing mechanism Jens Axboe
2013-10-24 9:39 ` Dave Jones
2013-10-24 9:50 ` Jens Axboe
2013-10-24 9:51 ` Christoph Hellwig
2013-10-24 9:26 ` [PATCH 11/11] null_blk: multi queue aware block test driver Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025104435.GC6285@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.p.zijlstra@chello.nl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox