From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, ak@linux.intel.com, acme@redhat.com,
zheng.z.yan@intel.com, bp@alien8.de
Subject: Re: [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support
Date: Fri, 25 Oct 2013 13:13:39 +0200 [thread overview]
Message-ID: <20131025111339.GA1219@krava.redhat.com> (raw)
In-Reply-To: <1382533085-7166-4-git-send-email-eranian@google.com>
On Wed, Oct 23, 2013 at 02:58:04PM +0200, Stephane Eranian wrote:
SNIP
> +
> + perf_cpu_notifier(rapl_cpu_notifier);
> +
> + ret = perf_pmu_register(&rapl_pmu_class, "power", -1);
> + WARN_ON(ret);
> + if (!ret) {
> + pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n");
> + put_online_cpus();
> + return -1;
> + }
should above rather be:
if (WARN_ON(ret)) {
pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n");
jirka
next prev parent reply other threads:[~2013-10-25 11:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 12:58 [PATCH v3 0/4] perf,x86: add Intel RAPL PMU support Stephane Eranian
2013-10-23 12:58 ` [PATCH v3 1/4] perf: add active_entry list head to struct perf_event Stephane Eranian
2013-10-25 14:56 ` Jiri Olsa
2013-10-26 16:57 ` Stephane Eranian
2013-10-26 17:44 ` Jiri Olsa
2013-10-28 9:58 ` Stephane Eranian
2013-10-23 12:58 ` [PATCH v3 2/4] perf stat: add event unit and scale support Stephane Eranian
2013-10-23 12:58 ` [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support Stephane Eranian
2013-10-25 11:13 ` Jiri Olsa [this message]
2013-10-25 11:13 ` Jiri Olsa
2013-10-25 11:14 ` Jiri Olsa
2013-10-26 17:00 ` Stephane Eranian
2013-10-28 10:33 ` Stephane Eranian
2013-10-28 12:17 ` Peter Zijlstra
2013-10-28 15:54 ` Stephane Eranian
2013-10-23 12:58 ` [PATCH v3 4/4] perf,x86: add RAPL hrtimer support Stephane Eranian
2013-10-25 17:44 ` Jiri Olsa
2013-10-26 17:07 ` Stephane Eranian
2013-10-26 17:53 ` Jiri Olsa
2013-10-28 9:55 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025111339.GA1219@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).