linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zubair Lutfullah :" <zubair.lutfullah@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	Zubair Lutfullah <zubair.lutfullah@gmail.com>,
	Felipe Balbi <balbi@ti.com>,
	kishon@ti.com
Subject: Re: [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of reg_lock
Date: Fri, 25 Oct 2013 20:29:24 +0500	[thread overview]
Message-ID: <20131025152922.GA4263@gmail.com> (raw)
In-Reply-To: <20131022171359.GC2620@lee--X1>

On Tue, Oct 22, 2013 at 06:13:59PM +0100, Lee Jones wrote:
> On Tue, 22 Oct 2013, Sebastian Andrzej Siewior wrote:
> 
> > Since the addition of continuous sampling mode and shared irq support,
> > the reg_lock lock can be taken with and without interrupts. This patch
> > uses the *_irq* variant which should be used in order to avaoid a deadlock.
> > 
> > Cc: Zubair Lutfullah <zubair.lutfullah@gmail.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> >  drivers/mfd/ti_am335x_tscadc.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> Good catch. Applied, thanks.

Had noticed this and forgot. My bad..

Thanks for catching it.

Zubair

      reply	other threads:[~2013-10-25 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 14:12 [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of reg_lock Sebastian Andrzej Siewior
2013-10-22 17:13 ` Lee Jones
2013-10-25 15:29   ` Zubair Lutfullah : [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131025152922.GA4263@gmail.com \
    --to=zubair.lutfullah@gmail.com \
    --cc=balbi@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=kishon@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).