From: Matt Porter <matt.porter@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Wendy Ng <wendy.ng@broadcom.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Eduardo Valentin <eduardo.valentin@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Christian Daudt <bcm@fixthebug.org>,
Markus Mayer <mmayer@broadcom.com>,
Tim Kryger <tim.kryger@linaro.org>
Subject: Re: [PATCH 1/3] thermal: bcm281xx: Add Temperature Monitor driver
Date: Sat, 26 Oct 2013 08:45:46 -0400 [thread overview]
Message-ID: <20131026124546.GH29341@beef> (raw)
In-Reply-To: <46DC9641-6D01-4D2F-B5C3-0942B480D6E0@codeaurora.org>
On Sat, Oct 26, 2013 at 01:47:40AM -0500, Kumar Gala wrote:
>
> On Oct 26, 2013, at 1:46 AM, Kumar Gala wrote:
>
> >
> > On Oct 25, 2013, at 7:00 PM, Wendy Ng wrote:
> >
> >> This adds the support for Temperature Monitor (TMON) driver for
> >> Broadcom bcm281xx SoCs. This driver plugs into the Thermal Framework.
> >>
> >> Note that this version of the TMON driver does support interrupt-driven
> >> mode -- only polling-mode of the thermal framework can be used.
> >>
> >> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
> >> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
> >> Reviewed-by: Christian Daudt <csd@broadcom.com>
> >> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> >> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> >> ---
> >> .../bindings/thermal/bcm-kona-thermal.txt | 24 +++
> >> drivers/thermal/Kconfig | 11 ++
> >> drivers/thermal/Makefile | 1 +
> >> drivers/thermal/bcm_kona_tmon.c | 173 ++++++++++++++++++++
> >> 4 files changed, 209 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
> >> create mode 100644 drivers/thermal/bcm_kona_tmon.c
> >>
> >> diff --git a/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
> >> new file mode 100644
> >> index 0000000..225b898
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt
> >> @@ -0,0 +1,24 @@
> >> +* Broadcom Kona TMON bindings
> >> +
> >> +This version is for the Kona family of SoCs. The TMON (Temperature Monitor)
> >> +block in a Kona SoC device is used to measure the chip temperature at constant
> >> +intervals.
> >> +The TMON block asserts an interrupt if temperature exceeds a user programmed
> >> +threshold value. The TMON block would reset the entire device once it
> >> +reaches a critical temperature which is also a programmable setting.
> >> +
> >> +Required properties:
> >> +- compatible : "brcm,bcm11351-tmon", "brcm,kona-tmon"
> >> +- reg : Address range of the thermal register
> >> +- clocks : the clock signal that drives the TMON block
> >> +- interrupts: the interrupt signal associated with the TMON block
> >> +
> >> +
> >> +Example:
> >> + tmon@34008000 {
> >> + compatible = "brcm,bcm11351-tmon", "brcm,kona-tmon";
> >> + reg = <0x34008000 0x0024>;
> >> + clocks = <&tmon_1m_clk>;
> >> + interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;
> >> + status = "disabled";
> >
> > I'd remove the 'status' line from an example.
> >
> >> + };
> >
> > Ack on the binding (beyond my minor nit pick on the status prop).
> >
> > Acked-by: Kumar Gala <galak@codeaurora.org>
> >
> > - k
>
>
> After looking at your .dts{i} I see you've got a #thermal-sensor-cells prop, where is that documented?
It's in Eduardo's "device thermal limits represented in device tree
nodes" series. Here's the direct link to the binding post/discussion
https://lkml.org/lkml/2013/9/26/772
-Matt
next prev parent reply other threads:[~2013-10-26 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 0:00 [PATCH 0/3] thermal: bcm281xx: Add Temperature Monitor driver Wendy Ng
2013-10-26 0:00 ` [PATCH 1/3] " Wendy Ng
2013-10-26 6:46 ` Kumar Gala
2013-10-26 6:47 ` Kumar Gala
2013-10-26 12:45 ` Matt Porter [this message]
2013-10-27 7:05 ` Kumar Gala
2013-10-27 13:48 ` Grant Likely
2013-10-26 0:00 ` [PATCH 2/3] ARM: configs:enable thermal framework for bcm281xx Wendy Ng
2013-10-26 0:00 ` [PATCH 3/3] ARM: dts: Add TMON driver support to bcm281xx Wendy Ng
2013-10-26 6:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131026124546.GH29341@beef \
--to=matt.porter@linaro.org \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=eduardo.valentin@ti.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tim.kryger@linaro.org \
--cc=wendy.ng@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox