From: Greg KH <gregkh@linuxfoundation.org>
To: Vishal Annapurve <vannapurve@nvidia.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Ming Lei <tom.leiming@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb-storage: scsiglue: Changing the command result
Date: Sat, 26 Oct 2013 20:33:48 -0700 [thread overview]
Message-ID: <20131027033348.GA10160@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1310261529050.24397-100000@netrider.rowland.org>
On Sat, 26 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> Here is the new patch:
>
> From: Vishal Annapurve <vannapurve@nvidia.com>
> Date: Sat, 26 Oct 2013 21:10:11 +0530
> Subject: [PATCH] usb: storage: Proper cmd result assignment
>
> This change replaces DID_ABORT with DID_TIMEOUT as a command result
> whenever US_FLIDX_TIMED_OUT bit is set.
>
> This change is made to bring USB storage inline with a recent change:
>
> commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8
>
> [SCSI] Handle disk devices which can not process medium access commands
> We have experienced several devices which fail in a fashion we do not
> currently handle gracefully in SCSI. After a failure these devices will
> respond to the SCSI primary command set (INQUIRY, TEST UNIT READY, etc.)
> but any command accessing the storage medium will time out.
>
> As the USB storage was setting command result as aborted rather than
> timed out, SCSI layer was not recognizing the above mentioned failure
> pattern.
>
> Change-Id: Ic58e2247fed11649f4dbea56382354ba2fe0be1b
What's this line for? (yeah, I know where it comes from, the point is
it doesn't belong here...)
Also, no signed-off-by, so I can't apply it...
greg k-h
next prev parent reply other threads:[~2013-10-27 3:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52441AA7.9070300@nvidia.com>
2013-09-26 11:35 ` [PATCH] usb-storage: scsiglue: Changing the command result Vishal Annapurve
2013-10-15 7:29 ` Ming Lei
2013-10-15 15:54 ` Alan Stern
2013-10-15 16:29 ` Vishal Annapurve
2013-10-15 17:02 ` Alan Stern
2013-10-15 17:53 ` Vishal Annapurve
2013-10-15 20:22 ` Alan Stern
2013-10-16 0:40 ` Ming Lei
2013-10-16 14:39 ` Alan Stern
2013-10-18 5:38 ` Vishal Annapurve
2013-10-18 14:10 ` Alan Stern
2013-10-19 11:32 ` Vishal Annapurve
2013-10-21 17:23 ` Alan Stern
2013-10-26 15:49 ` Vishal Annapurve
2013-10-26 19:33 ` Alan Stern
2013-10-27 3:33 ` Greg KH [this message]
2013-11-16 6:53 Vishal Annapurve
2013-11-18 15:08 ` Alan Stern
2013-12-09 1:59 ` Greg KH
2013-12-09 9:44 ` Vishal Annapurve
2013-12-09 9:55 ` Oliver Neukum
2013-12-09 11:23 ` Greg KH
2013-12-10 5:23 ` Vishal Annapurve
2013-12-10 5:55 ` Greg KH
2013-12-10 11:37 ` Vishal Annapurve
-- strict thread matches above, loose matches on Subject: below --
2013-11-16 6:55 Vishal Annapurve
2013-11-16 6:55 Vishal Annapurve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027033348.GA10160@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
--cc=vannapurve@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox