From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kevin McKinney <klmckinney1@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/11] Staging: bcm: Replace ULONG with unsigned long in Adapter.h
Date: Sun, 27 Oct 2013 11:20:52 +0300 [thread overview]
Message-ID: <20131027082052.GL5871@mwanda> (raw)
In-Reply-To: <1382768120-23380-5-git-send-email-klmckinney1@gmail.com>
On Sat, Oct 26, 2013 at 02:15:14AM -0400, Kevin McKinney wrote:
> This patch replace "ULONG" with "unsigned
> long" in Adapter.h
>
> Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
> ---
> drivers/staging/bcm/Adapter.h | 42 ++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index eaf9532..4c9662b 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -37,12 +37,12 @@ struct bcm_link_request {
>
> union bcm_ip_address {
> struct {
> - ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
> - ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */
> + unsigned long ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */
These aren't correct in the original code btw. ipv4 addresses should
fit in a u32. Also it's not clear how this address is used.
It's something to think about and maybe remove or fix in later patches.
regards,
dan carpenter
next prev parent reply other threads:[~2013-10-27 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 6:15 [PATCH 01/11] Staging: bcm: Fix WARNING: space prohibited before semicolon Kevin McKinney
2013-10-26 6:15 ` [PATCH 02/11] Staging: bcm: Remove typedef for _U_IP_ADDRESS and call directly Kevin McKinney
2013-10-26 6:15 ` [PATCH 03/11] Staging: bcm: Replace USHORT with unsigned short in Adapter.h Kevin McKinney
2013-10-26 6:15 ` [PATCH 04/11] Staging: bcm: Replace UCHAR with unsigned char " Kevin McKinney
2013-10-27 8:25 ` Dan Carpenter
2013-10-27 23:55 ` Kevin McKinney
2013-10-26 6:15 ` [PATCH 05/11] Staging: bcm: Replace ULONG with unsigned long " Kevin McKinney
2013-10-27 8:20 ` Dan Carpenter [this message]
2013-10-26 6:15 ` [PATCH 06/11] Staging: bcm: Replace B_UINT16 with u16 " Kevin McKinney
2013-10-26 6:15 ` [PATCH 07/11] Staging: bcm: Replace B_UINT8 with u8 " Kevin McKinney
2013-10-26 6:15 ` [PATCH 08/11] Staging: bcm: Replace UINT32 with u32 " Kevin McKinney
2013-10-26 6:15 ` [PATCH 09/11] Staging: bcm: Replace UINT with unsigned int " Kevin McKinney
2013-10-26 6:15 ` [PATCH 10/11] Staging: bcm: Replace PVOID with void * " Kevin McKinney
2013-10-26 6:15 ` [PATCH 11/11] Staging: bcm: Replace BOOLEAN with bool " Kevin McKinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027082052.GL5871@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).