* [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
@ 2013-10-27 16:13 Rob Pearce
2013-10-27 17:33 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Rob Pearce @ 2013-10-27 16:13 UTC (permalink / raw)
To: Daniel Vetter; +Cc: David Airlie, intel-gfx, dri-devel, linux-kernel
From: Rob Pearce <rob@flitspace.org.uk>
The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
having LVDS but the hardware is not populated. This patch adds them to
the list of such systems. Patch is against 3.11.4
Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
---
Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
According to Intel's documentation, the D410PTL and D410PLTW don't.
diff -uprN -X linux-3.11.4/Documentation/dontdiff linux-3.11.4/drivers/gpu/drm/i915/intel_lvds.c linux-3.11.4-ovs/drivers/gpu/drm/i915/intel_lvds.c
--- linux-3.11.4/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100
+++ linux-3.11.4-ovs/drivers/gpu/drm/i915/intel_lvds.c 2013-10-27 15:51:25.000000000 +0000
@@ -696,6 +696,22 @@
},
{
.callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D410PT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D425KT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "D425KT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
.ident = "Intel D510MO",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 16:13 [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT Rob Pearce
@ 2013-10-27 17:33 ` Greg KH
2013-10-27 18:07 ` Daniel Vetter
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Greg KH @ 2013-10-27 17:33 UTC (permalink / raw)
To: Rob Pearce
Cc: Daniel Vetter, David Airlie, intel-gfx, dri-devel, linux-kernel
On Sun, Oct 27, 2013 at 04:13:42PM +0000, Rob Pearce wrote:
> From: Rob Pearce <rob@flitspace.org.uk>
>
> The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
> having LVDS but the hardware is not populated. This patch adds them to
> the list of such systems. Patch is against 3.11.4
>
> Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
> ---
> Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
> According to Intel's documentation, the D410PTL and D410PLTW don't.
Any reason you don't want this in the stable tree as well?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 17:33 ` Greg KH
@ 2013-10-27 18:07 ` Daniel Vetter
2013-10-27 18:29 ` Rob Pearce
2013-10-27 18:35 ` Guenter Roeck
2 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2013-10-27 18:07 UTC (permalink / raw)
To: Greg KH
Cc: Rob Pearce, Daniel Vetter, David Airlie, intel-gfx, dri-devel,
linux-kernel
On Sun, Oct 27, 2013 at 10:33:02AM -0700, Greg KH wrote:
> On Sun, Oct 27, 2013 at 04:13:42PM +0000, Rob Pearce wrote:
> > From: Rob Pearce <rob@flitspace.org.uk>
> >
> > The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
> > having LVDS but the hardware is not populated. This patch adds them to
> > the list of such systems. Patch is against 3.11.4
> >
> > Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
> > ---
> > Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
> > According to Intel's documentation, the D410PTL and D410PLTW don't.
>
> Any reason you don't want this in the stable tree as well?
None. Picked up for -fixes, thanks for the patch. Also I prefer the patch
change log in the commit message proper and less screaming in the summary
;-) All fixed while applying.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 17:33 ` Greg KH
2013-10-27 18:07 ` Daniel Vetter
@ 2013-10-27 18:29 ` Rob Pearce
2013-10-27 18:35 ` Guenter Roeck
2 siblings, 0 replies; 9+ messages in thread
From: Rob Pearce @ 2013-10-27 18:29 UTC (permalink / raw)
To: Greg KH; +Cc: Daniel Vetter, David Airlie, intel-gfx, dri-devel, linux-kernel
On 27/10/13 17:33, Greg KH wrote:
> On Sun, Oct 27, 2013 at 04:13:42PM +0000, Rob Pearce wrote:
>> From: Rob Pearce <rob@flitspace.org.uk>
>>
>> The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
>> having LVDS but the hardware is not populated. This patch adds them to
>> the list of such systems. Patch is against 3.11.4
>>
>> Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
>> ---
>> Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
>> According to Intel's documentation, the D410PTL and D410PLTW don't.
>
> Any reason you don't want this in the stable tree as well?
>
No, should be in stable. Sorry, I'm obviously getting some etiquette
wrong (this is the first patch I've submitted).
Cheers,
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 17:33 ` Greg KH
2013-10-27 18:07 ` Daniel Vetter
2013-10-27 18:29 ` Rob Pearce
@ 2013-10-27 18:35 ` Guenter Roeck
2013-10-27 19:29 ` Daniel Vetter
2 siblings, 1 reply; 9+ messages in thread
From: Guenter Roeck @ 2013-10-27 18:35 UTC (permalink / raw)
To: Greg KH, Rob Pearce
Cc: Daniel Vetter, David Airlie, intel-gfx, dri-devel, linux-kernel
On 10/27/2013 10:33 AM, Greg KH wrote:
> On Sun, Oct 27, 2013 at 04:13:42PM +0000, Rob Pearce wrote:
>> From: Rob Pearce <rob@flitspace.org.uk>
>>
>> The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
>> having LVDS but the hardware is not populated. This patch adds them to
>> the list of such systems. Patch is against 3.11.4
>>
>> Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
>> ---
>> Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
>> According to Intel's documentation, the D410PTL and D410PLTW don't.
>
> Any reason you don't want this in the stable tree as well?
>
Hi Greg,
pardon my ignorance, but I thought this was supposed to be the maintainer's call to make ?
Did I get this wrong ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 18:35 ` Guenter Roeck
@ 2013-10-27 19:29 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2013-10-27 19:29 UTC (permalink / raw)
To: Guenter Roeck
Cc: Greg KH, Rob Pearce, Daniel Vetter, David Airlie, intel-gfx,
dri-devel, linux-kernel
On Sun, Oct 27, 2013 at 11:35:58AM -0700, Guenter Roeck wrote:
> On 10/27/2013 10:33 AM, Greg KH wrote:
> >On Sun, Oct 27, 2013 at 04:13:42PM +0000, Rob Pearce wrote:
> >>From: Rob Pearce <rob@flitspace.org.uk>
> >>
> >>The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
> >>having LVDS but the hardware is not populated. This patch adds them to
> >>the list of such systems. Patch is against 3.11.4
> >>
> >>Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
> >>---
> >>Patch revised to match the D425KT exactly as the D425KTW does have LVDS.
> >>According to Intel's documentation, the D410PTL and D410PLTW don't.
> >
> >Any reason you don't want this in the stable tree as well?
> >
>
> Hi Greg,
>
> pardon my ignorance, but I thought this was supposed to be the maintainer's call to make ?
> Did I get this wrong ?
Maintainer occasionally fumble it, so it's better when the patch submitter
also thinks about this. I can always change it when I disagree ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
@ 2013-10-27 13:35 Rob Pearce
2013-10-27 13:51 ` Daniel Vetter
0 siblings, 1 reply; 9+ messages in thread
From: Rob Pearce @ 2013-10-27 13:35 UTC (permalink / raw)
To: Daniel Vetter; +Cc: David Airlie, intel-gfx, dri-devel, linux-kernel
From: Rob Pearce <rob@flitspace.org.uk>
These Intel D410PT and D425KT Mini-ITX desktop boards both show up as
having LVDS but the hardware is not populated. This patch adds them to
the list of such systems. Tested against 3.9.10 and 3.11.4
Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
---
diff -uprN -X linux-3.9.10/Documentation/dontdiff linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c
--- linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100
+++ linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 18:58:56.000000000 +0100
@@ -843,6 +843,22 @@
},
{
.callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D410PT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D425KT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_MATCH(DMI_BOARD_NAME, "D425KT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
.ident = "Supermicro X7SPA-H",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 13:35 Rob Pearce
@ 2013-10-27 13:51 ` Daniel Vetter
2013-10-27 16:06 ` Rob Pearce
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Vetter @ 2013-10-27 13:51 UTC (permalink / raw)
To: Rob Pearce
Cc: Daniel Vetter, David Airlie, intel-gfx, dri-devel, linux-kernel
On Sun, Oct 27, 2013 at 01:35:30PM +0000, Rob Pearce wrote:
> From: Rob Pearce <rob@flitspace.org.uk>
>
> These Intel D410PT and D425KT Mini-ITX desktop boards both show up as
> having LVDS but the hardware is not populated. This patch adds them to
> the list of such systems. Tested against 3.9.10 and 3.11.4
>
> Signed-off-by: Rob Pearce <rob@flitspace.org.uk>
> ---
> diff -uprN -X linux-3.9.10/Documentation/dontdiff linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c
> --- linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100
> +++ linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 18:58:56.000000000 +0100
> @@ -843,6 +843,22 @@
> },
> {
> .callback = intel_no_lvds_dmi_callback,
> + .ident = "Intel D410PT",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
> + DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
> + },
> + },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> + .ident = "Intel D425KT",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
> + DMI_MATCH(DMI_BOARD_NAME, "D425KT"),
At least this one here has a KTW variant with lvds connector. I think we
need a DMI_EXACT_MATCH. I haven't found out whether the D410PT board also
has such a cousin, so please digg in a bit for me.
Thanks, Daniel
> + },
> + },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> .ident = "Supermicro X7SPA-H",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT
2013-10-27 13:51 ` Daniel Vetter
@ 2013-10-27 16:06 ` Rob Pearce
0 siblings, 0 replies; 9+ messages in thread
From: Rob Pearce @ 2013-10-27 16:06 UTC (permalink / raw)
To: David Airlie, intel-gfx, dri-devel, linux-kernel, Daniel Vetter
Hi Daniel,
On 27/10/13 13:51, Daniel Vetter wrote:
>> + .matches = {
>> > + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
>> > + DMI_MATCH(DMI_BOARD_NAME, "D425KT"),
> At least this one here has a KTW variant with lvds connector. I think we
> need a DMI_EXACT_MATCH. I haven't found out whether the D410PT board also
> has such a cousin, so please digg in a bit for me.
>
Yes, you're right, sorry. I've had a dig and it looks like the D410PT
variants don't have LVDS (the differences in that range are legacy I/O,
PCIe and wireless). I'll re-submit with the 425 as an exact match.
Regards,
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-27 19:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-27 16:13 [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT Rob Pearce
2013-10-27 17:33 ` Greg KH
2013-10-27 18:07 ` Daniel Vetter
2013-10-27 18:29 ` Rob Pearce
2013-10-27 18:35 ` Guenter Roeck
2013-10-27 19:29 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2013-10-27 13:35 Rob Pearce
2013-10-27 13:51 ` Daniel Vetter
2013-10-27 16:06 ` Rob Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox