From: Matt Fleming <matt@console-pimps.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, Tony Luck <tony.luck@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
X86-ML <x86@kernel.org>
Subject: Re: [GIT PULLv2] For x86/mce ... enhanced error logs
Date: Sun, 27 Oct 2013 20:22:15 +0000 [thread overview]
Message-ID: <20131027202215.GD1982@console-pimps.org> (raw)
In-Reply-To: <20131027110148.GA24817@pd.tnic>
On Sun, 27 Oct, at 12:01:48PM, Borislav Petkov wrote:
> On Sun, Oct 27, 2013 at 08:00:35AM +0100, Ingo Molnar wrote:
> >
> > * Tony Luck <tony.luck@gmail.com> wrote:
> >
> > > > Hm, I'm not sure we should move something named after a hardware
> > > > feature into lib/. It's not really generic C library functionality,
> > >
> > >
> > > Not a hardware feature. CPER stands for Common Platform Error Record
> > > from the UEFI standard. [...]
> >
> > By all means UEFI can be considered platform dependent at the moment:
> >
> > comet:~/tip> git grep -i uefi arch/arm/
> > comet:~/tip> git grep -i uefi arch/arm64/
> > comet:~/tip> git grep -i uefi arch/powerpc/
> > comet:~/tip> git grep -i uefi arch/mips/
> > comet:~/tip>
> >
> > If a committee says that a name of some standard is 'common platform' does
> > not make it so. lib/ is mostly kept for mathematical, C-library alike
> > functionality you see in CS textbooks.
> >
> > > As Chen Gong points out, drivers/acpi isn't the right place ... so if
> > > not lib/ ... then where?
> >
> > drivers/uefi/?
>
> Hmm, we do have drivers/firmware/, even drivers/firmware/efi/ subdir and
> since this thing is part of the UEFI spec, we probably should stick it
> there...
I've certainly no problem with moving it under drivers/firmware/efi/,
but please don't create a new subdirectory in drivers/ just for this.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-27 20:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 17:56 [GIT PULL] For x86/mce ... enhanced error logs Luck, Tony
2013-10-23 17:42 ` [GIT PULLv2] " Luck, Tony
2013-10-23 18:13 ` Tony Luck
2013-10-26 10:10 ` Ingo Molnar
2013-10-26 21:34 ` Tony Luck
2013-10-26 21:36 ` Christoph Hellwig
2013-10-27 7:00 ` Ingo Molnar
2013-10-27 11:01 ` Borislav Petkov
2013-10-27 20:22 ` Matt Fleming [this message]
2013-10-27 20:34 ` Borislav Petkov
2013-10-27 20:46 ` Matt Fleming
2013-10-28 18:53 ` [PATCH] Move cper.c from drivers/acpi/apei to drivers/firmware/efi Luck, Tony
2013-10-28 20:35 ` Matt Fleming
2013-10-29 8:16 ` Ingo Molnar
2013-10-26 10:06 ` [GIT PULLv2] For x86/mce ... enhanced error logs Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027202215.GD1982@console-pimps.org \
--to=matt@console-pimps.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tony.luck@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).