From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.fedoraproject.org, kexec@lists.infradead.org
Subject: Re: [patch 2/6] x86 efi: reserve boot service fix
Date: Mon, 28 Oct 2013 09:18:24 +0800 [thread overview]
Message-ID: <20131028011824.GD4397@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <20131027203058.GE1982@console-pimps.org>
On 10/27/13 at 08:30pm, Matt Fleming wrote:
> On Sun, 27 Oct, at 11:50:09AM, Borislav Petkov wrote:
> > On Sun, Oct 27, 2013 at 11:47:15AM +0800, dyoung@redhat.com wrote:
> > > Current code check boot service region with kernel text region by:
> > > start+size >= __pa_symbol(_text)
> > > The end of the above region should be start + size - 1 instead.
> > >
> > > I see this problem in ovmf + Fedora 19 grub boot:
> > > text start: 1000000 md start: 800000 md size: 800000
> > >
> > > Signed-off-by: Dave Young <dyoung@redhat.com>
> >
> > Acked-by: Borislav Petkov <bp@suse.de>
> >
> > Btw, Matt, this being a bugfix and all, shouldn't it be tagged for
> > stable?
>
> Well that depends. Dave, am I correct in thinking that you only noticed
> this bug when writing kexec support? I'm inclined not to bother with a
> stable tag if no one has ever noticed any fallout from this bug until
> now.
There should be some people see below message with non-kexec kernel:
"Could not reserve boot range ..."
But it's hard for them to notice the bad functionality because it's only
one mem range which might be not the boot range what SetVirtualAddressMap need
next prev parent reply other threads:[~2013-10-28 1:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 3:47 [patch 0/6] kexec kernel efi runtime support dyoung
2013-10-27 3:47 ` [patch 1/6] Add function efi_remap_region for remapping to saved virt address dyoung
2013-10-27 11:50 ` Borislav Petkov
2013-10-28 1:25 ` Dave Young
2013-10-27 3:47 ` [patch 3/6] Cleanup efi_enter_virtual_mode function dyoung
2013-10-28 9:32 ` Borislav Petkov
2013-10-28 9:40 ` Dave Young
2013-10-28 9:51 ` Dave Young
2013-10-28 10:04 ` Borislav Petkov
2013-10-28 10:10 ` Dave Young
2013-10-28 10:39 ` Dave Young
2013-10-28 11:20 ` Borislav Petkov
2013-10-28 11:24 ` Dave Young
2013-10-28 14:58 ` Borislav Petkov
2013-10-28 15:10 ` Dave Young
2013-10-29 2:32 ` Dave Young
2013-10-29 13:43 ` Borislav Petkov
2013-10-30 2:03 ` Dave Young
2013-10-30 10:47 ` Borislav Petkov
2013-10-31 2:04 ` Dave Young
2013-10-31 2:07 ` Dave Young
2013-10-31 3:07 ` H. Peter Anvin
2013-10-31 10:45 ` Borislav Petkov
2013-11-01 1:15 ` Dave Young
2013-10-31 10:44 ` Borislav Petkov
2013-11-01 1:18 ` Dave Young
2013-11-01 11:32 ` Borislav Petkov
2013-10-27 3:47 ` [patch 4/6] export more efi table variable to sysfs dyoung
2013-10-27 3:47 ` [patch 5/6] export efi runtime memory mapping " dyoung
2013-10-29 5:34 ` Dave Young
2013-10-27 3:47 ` [patch 6/6] passing kexec necessary efi data via setup_data dyoung
[not found] ` <20131027035922.924386710@dhcp-16-126.nay.redhat.com>
2013-10-27 10:50 ` [patch 2/6] x86 efi: reserve boot service fix Borislav Petkov
2013-10-27 20:30 ` Matt Fleming
2013-10-28 1:18 ` Dave Young [this message]
2013-10-28 8:44 ` Borislav Petkov
2013-10-28 10:27 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028011824.GD4397@dhcp-16-126.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.fedoraproject.org \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).