From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexander Gordeev <agordeev@redhat.com>,
Tejun Heo <tj@kernel.org>,
Nicholas Bellinger <nab@linux-iscsi.org>,
linux-kernel@vger.kernel.org
Subject: Re: blk-mq flush fix
Date: Mon, 28 Oct 2013 01:48:21 -0700 [thread overview]
Message-ID: <20131028084821.GA31270@infradead.org> (raw)
In-Reply-To: <20131027222914.GG22549@kernel.dk>
On Sun, Oct 27, 2013 at 10:29:25PM +0000, Jens Axboe wrote:
> On Sat, Oct 26 2013, Christoph Hellwig wrote:
> > I think this variant of the patch from Alexander should fix the issue
> > in a minimally invasive way. Longer term I'd prefer to use q->flush_rq
> > like in the non-mq case by copying over the context and tag information.
>
> This one is pretty simple, we could definitely use it as a band aid. I
> too would greatly prefer using the static ->flush_rq instead. Just have
> it marked to bypass most of the free logic.
We already bypass the free logical by setting and end_io callback for
a while, similar to what the old code does. Maybe it's not all that
hard to prealloc the request, let me give a sping. Using the static
allocated one will be hard due to the driver-specific extra data,
though.
> I'll add this one.
Gimme another day or so to figure this out.
next prev parent reply other threads:[~2013-10-28 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 11:46 blk-mq flush fix Christoph Hellwig
2013-10-26 15:31 ` Christoph Hellwig
2013-10-27 22:29 ` Jens Axboe
2013-10-28 8:48 ` Christoph Hellwig [this message]
2013-10-28 16:29 ` Jens Axboe
2013-10-28 16:46 ` Christoph Hellwig
2013-10-28 16:59 ` Jens Axboe
2013-10-28 19:30 ` Christoph Hellwig
2013-10-28 19:39 ` Jens Axboe
[not found] ` <CANejiEWyznEOtRAXrsgEqGoo2EWJDGBt7XH4AZFksWSmR4UY+Q@mail.gmail.com>
2013-10-28 19:38 ` Jens Axboe
2013-10-28 19:47 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028084821.GA31270@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).