From: Andreas Werner <wernerandy@gmx.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, dave@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr
Date: Mon, 28 Oct 2013 11:34:28 +0100 [thread overview]
Message-ID: <20131028103428.GA2278@thinkpad.fritz.box> (raw)
In-Reply-To: <20131028101749.GA4389@gmail.com>
On Mon, Oct 28, 2013 at 11:17:49AM +0100, Ingo Molnar wrote:
>
> * Andreas Werner <wernerandy@gmx.de> wrote:
>
> > > IOW, you probably could use a WC buffer here too, as it would
> > > combine the writes coming from the FPGA.
> > >
> > > Btw, there's also mtrr_add(..., MTRR_TYPE_WRTHROUGH, ) if you
> > > must use a WT thing. Have you tried that?
> >
> > For reading i need to map the mmio with attributes that allow
> > cache-line read. Therefore i use WT. For the Virtual address i use
> > ioremap_cache in combination with this patch to get an effective
> > memory type of "Write-Through". This allows me to read from the
> > mmio with "PCIe burst". The write behaviour to this region do not
> > matter.
>
> And regular write-back cacheable isn't sufficient because the CPU
> could do things like prefetch your range automatically?
>
> If the reads are for packet data and not for commands, WB could
> still be beneficial as it should allow even higher bandwidth. (For
> non-data with real semantics WB is probably not good.)
>
> Thanks,
>
> Ingo
Yes the reads are only for packet data, the commands or configuration
registers are mapped non cachable.
I´ve tried WB, but on PCIe Tracer i could not see any burst access.
Thats the reason why i have created this patch.
Is there a chance to get this patch into the kernel? Or
is this solution so special?
Regards
Andy
next prev parent reply other threads:[~2013-10-28 10:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 12:55 [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr Andreas Werner
2013-10-27 13:34 ` Borislav Petkov
2013-10-27 16:51 ` Andreas Werner
2013-10-27 17:31 ` Borislav Petkov
2013-10-27 17:56 ` Andreas Werner
2013-10-27 19:01 ` Borislav Petkov
2013-10-28 6:29 ` Andreas Werner
2013-10-28 10:17 ` Ingo Molnar
2013-10-28 10:29 ` Borislav Petkov
2013-10-28 10:31 ` Ingo Molnar
2013-10-28 10:44 ` Borislav Petkov
2013-10-28 10:45 ` Andreas Werner
2013-10-28 10:51 ` Ingo Molnar
2013-10-28 10:53 ` H. Peter Anvin
2013-10-28 11:02 ` Andreas Werner
2013-10-28 10:31 ` H. Peter Anvin
2013-10-28 10:34 ` Andreas Werner [this message]
2013-10-28 10:57 ` Borislav Petkov
2013-10-28 11:25 ` Andreas Werner
2013-10-28 11:45 ` Borislav Petkov
2013-10-28 12:03 ` Andreas Werner
2013-10-28 13:58 ` Borislav Petkov
2013-10-28 14:19 ` Andreas Werner
-- strict thread matches above, loose matches on Subject: below --
2013-08-25 7:01 Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028103428.GA2278@thinkpad.fritz.box \
--to=wernerandy@gmx.de \
--cc=bp@alien8.de \
--cc=dave@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).