From: Ingo Molnar <mingo@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
mingo@elte.hu, tglx@linutronix.de,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
arjan@linux.intel.com, linux@roeck-us.net,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH 1/2] x86: unify copy_from_user() size checking
Date: Mon, 28 Oct 2013 11:55:19 +0100 [thread overview]
Message-ID: <20131028105519.GA7798@gmail.com> (raw)
In-Reply-To: <526E1EFA02000078000FD1E7@nat28.tlf.novell.com>
* Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 26.10.13 at 12:31, Ingo Molnar <mingo@kernel.org> wrote:
> > * Jan Beulich <JBeulich@suse.com> wrote:
> >> I'd like to point out though that with __compiletime_object_size()
> >> being restricted to gcc before 4.6, the whole construct is going to
> >> become more and more pointless going forward. I would question
> >> however that commit 2fb0815c9ee6b9ac50e15dd8360ec76d9fa46a2 ("gcc4:
> >> disable __compiletime_object_size for GCC 4.6+") was really necessary,
> >> and instead this should have been dealt with as is done here from the
> >> beginning.
> >
> > Can we now revert 2fb0815c9ee6?
>
> Afaict yes, but I certainly didn't test with all possible gcc
> versions. So minimally everyone involved in getting that change in
> would be good to be in agreement.
Mind submitting a patch? I can keep it pending until v3.14, that
should give time for compiler dependencies to be caught. Even if it
breaks anything it shouldn't be too hard to revert again ;-)
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-28 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 8:43 [PATCH 1/2] x86: unify copy_from_user() size checking Jan Beulich
2013-10-26 10:31 ` Ingo Molnar
2013-10-26 16:05 ` Guenter Roeck
2013-10-28 7:23 ` Jan Beulich
2013-10-28 10:55 ` Ingo Molnar [this message]
2013-10-29 9:43 ` Jan Beulich
2013-10-29 9:54 ` Ingo Molnar
2013-10-29 10:08 ` Jan Beulich
2013-10-29 10:12 ` Ingo Molnar
2013-11-25 16:15 ` [PATCH] x86: override __compiletime_object_size() Jan Beulich
2013-11-27 14:03 ` Ingo Molnar
2013-11-27 14:20 ` Jan Beulich
2013-11-27 14:36 ` Ingo Molnar
2013-10-26 13:51 ` [tip:x86/asm] x86: Unify copy_from_user() size checking tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028105519.GA7798@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).