From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756590Ab3J1NoT (ORCPT ); Mon, 28 Oct 2013 09:44:19 -0400 Received: from mail-ee0-f47.google.com ([74.125.83.47]:52227 "EHLO mail-ee0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756004Ab3J1NoR (ORCPT ); Mon, 28 Oct 2013 09:44:17 -0400 Date: Mon, 28 Oct 2013 14:44:13 +0100 From: Ingo Molnar To: Matt Fleming Cc: "H. Peter Anvin" , Thomas Gleixner , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] EFI changes Message-ID: <20131028134413.GA10163@gmail.com> References: <20131028123528.GM1982@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131028123528.GM1982@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matt Fleming wrote: > This is a respin of the EFI earlyprintk support with the fix for the > allmodconfig build breakage that Ingo reported. > > The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5: > > boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next > > for you to fetch changes up to 265434a91cf3377d65dc2b6d80065271514b5696: > > x86/efi: Add EFI framebuffer earlyprintk support (2013-10-28 11:57:58 +0000) > > ---------------------------------------------------------------- > * Add support for earlyprintk=efi which uses the EFI framebuffer. Very > useful for debugging boot issues. > > ---------------------------------------------------------------- > Matt Fleming (2): > efi: Add asm-generic/efi.h for non-x86 > x86/efi: Add EFI framebuffer earlyprintk support > > Documentation/kernel-parameters.txt | 8 +- > arch/ia64/include/asm/efi.h | 6 ++ > arch/x86/Kconfig.debug | 10 ++ > arch/x86/boot/compressed/eboot.c | 1 - > arch/x86/include/asm/efi.h | 12 +++ > arch/x86/kernel/early_printk.c | 6 ++ > arch/x86/kernel/setup.c | 1 - > arch/x86/platform/efi/Makefile | 1 + > arch/x86/platform/efi/early_printk.c | 191 +++++++++++++++++++++++++++++++++++ > arch/x86/platform/efi/efi.c | 1 - > arch/x86/platform/efi/efi_32.c | 1 - > arch/x86/platform/efi/efi_64.c | 1 - > arch/x86/platform/uv/bios_uv.c | 1 - > include/asm-generic/efi.h | 17 ++++ > include/linux/efi.h | 31 +----- > 15 files changed, 250 insertions(+), 38 deletions(-) > create mode 100644 arch/ia64/include/asm/efi.h > create mode 100644 arch/x86/platform/efi/early_printk.c > create mode 100644 include/asm-generic/efi.h and this breaks the ARM build: In file included from /home/mingo/tip/init/main.c:44: /home/mingo/tip/include/linux/efi.h:842:21: error: asm/efi.h: No such file or directory /home/mingo/tip/init/main.c: In function 'start_kernel': /home/mingo/tip/init/main.c:638: error: implicit declaration of function 'efi_enabled' /home/mingo/tip/init/main.c:639: error: implicit declaration of function 'efi_late_init' /home/mingo/tip/init/main.c:640: error: implicit declaration of function 'efi_free_boot_services' Thanks, Ingo