From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756978Ab3J1Pza (ORCPT ); Mon, 28 Oct 2013 11:55:30 -0400 Received: from mail-ea0-f178.google.com ([209.85.215.178]:42055 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756280Ab3J1Pz2 (ORCPT ); Mon, 28 Oct 2013 11:55:28 -0400 Date: Mon, 28 Oct 2013 16:55:25 +0100 From: Ingo Molnar To: Matt Fleming Cc: "H. Peter Anvin" , Thomas Gleixner , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] EFI changes Message-ID: <20131028155525.GA13987@gmail.com> References: <20131028123528.GM1982@console-pimps.org> <20131028134413.GA10163@gmail.com> <20131028155215.GN1982@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131028155215.GN1982@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matt Fleming wrote: > On Mon, 28 Oct, at 02:44:13PM, Ingo Molnar wrote: > > and this breaks the ARM build: > > > > In file included from /home/mingo/tip/init/main.c:44: > > /home/mingo/tip/include/linux/efi.h:842:21: error: asm/efi.h: No such file or directory > > /home/mingo/tip/init/main.c: In function 'start_kernel': > > /home/mingo/tip/init/main.c:638: error: implicit declaration of function 'efi_enabled' > > /home/mingo/tip/init/main.c:639: error: implicit declaration of function 'efi_late_init' > > /home/mingo/tip/init/main.c:640: error: implicit declaration of function 'efi_free_boot_services' > > Ah, that's my own fault because my 'next' branch doesn't include > the ARM EFI support. Where did you get the patches from? Are they > in linux-next? It's all in tip:x86/efi. > I'm inclined to drop the cleanup patch for now and do it later, > once things have settled because it's also causing conflicts for > Borislav's work. Sure. Thanks, Ingo