From: Minchan Kim <minchan@kernel.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: opw-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiang Liu <jiang.liu@huawei.com>, Nitin Gupta <ngupta@vflare.org>,
Jerome Marchand <jmarchand@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] Staging: zram: Fix decrement of variable by calling bdput()
Date: Tue, 29 Oct 2013 09:47:18 +0900 [thread overview]
Message-ID: <20131029004718.GD17038@bbox> (raw)
In-Reply-To: <7d016b6c725b88e5f61e21daaacf6c2e205537e0.1382962788.git.rashika.kheria@gmail.com>
On Mon, Oct 28, 2013 at 05:54:39PM +0530, Rashika Kheria wrote:
> As suggested by Jerome Marchand "The code in reset_store get the block device
> (bdget_disk()) but it does not put it (bdput()) when it's done using it.
> The usage count is therefor incremented but never decremented."
>
> Hence, this patch introduces a call to bdput() to decrement the variable after usage.
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
I think this patch is for stable, too.
So, please read my previous reply.
And please relocate this with [2/3] and do bdput in all of error cases
in reset_store.
> ---
> drivers/staging/zram/zram_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 9027975..98dac15 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -664,6 +664,7 @@ static ssize_t reset_store(struct device *dev,
>
> /* Make sure all pending I/O is finished */
> fsync_bdev(bdev);
> + bdput(bdev);
>
> zram_reset_device(zram, true);
> return len;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2013-10-29 0:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131019110539.GA25167@gmail.com>
2013-10-28 11:47 ` [PATCH v5 1/3] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-28 11:48 ` [PATCH v5 3/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-28 12:17 ` [PATCH v5 2/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-28 12:21 ` [PATCH v6 1/3] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-28 12:23 ` [PATCH v6 2/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-29 0:44 ` Minchan Kim
2013-10-28 12:24 ` [PATCH v6 3/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-29 0:47 ` Minchan Kim [this message]
2013-10-28 13:45 ` [PATCH v6 1/3] Staging: zram: Fix access of NULL pointer Weijie Yang
[not found] ` <CAMpEsFHO5yrwxK9q=hQtOxwC=0_p4BznBGjvomPgFZogwXABRA@mail.gmail.com>
2013-10-28 15:09 ` Weijie Yang
2013-10-29 0:43 ` Minchan Kim
2013-10-29 23:10 ` [PATCH v7 " Rashika Kheria
2013-10-29 23:12 ` [PATCH v7 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-30 2:33 ` Minchan Kim
2013-10-29 23:15 ` [PATCH v7 3/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-30 2:35 ` Minchan Kim
2013-10-30 10:44 ` Jerome Marchand
2013-10-30 2:24 ` [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer Minchan Kim
2013-10-30 2:36 ` Minchan Kim
2013-10-30 10:42 ` Jerome Marchand
2013-10-30 13:06 ` [PATCH v8 " Rashika Kheria
2013-10-30 13:10 ` [PATCH v8 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-31 9:42 ` Weijie Yang
2013-10-30 13:13 ` [PATCH v8 3/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-30 16:36 ` Greg Kroah-Hartman
2013-10-31 11:56 ` [PATCH v9 1/2] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-31 11:58 ` [PATCH v9 2/2] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-11-01 2:00 ` Minchan Kim
2013-11-01 8:54 ` Jerome Marchand
2013-11-01 14:13 ` Rashika Kheria
2013-11-01 14:06 ` [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch Rashika Kheria
2013-11-10 15:45 ` Greg Kroah-Hartman
2013-11-10 15:56 ` [OPW kernel] " Rashika Kheria
2013-11-10 16:10 ` Greg Kroah-Hartman
2013-11-10 16:14 ` Rashika Kheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029004718.GD17038@bbox \
--to=minchan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=jmarchand@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=opw-kernel@googlegroups.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox