From: Stanislav Fomichev <stfomichev@yandex-team.ru>
To: Namhyung Kim <namhyung@kernel.org>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data
Date: Tue, 29 Oct 2013 13:33:29 +0400 [thread overview]
Message-ID: <20131029093329.GC3406@stfomichev-desktop> (raw)
In-Reply-To: <87ppqo5wgx.fsf@sejong.aot.lge.com>
> Hmm.. double negation is always confusing to me. :-/ How about making
> it a boolean option that sets "task_only" variable?
Ok.
> Also need to update the doc. And what if user gives -P and -T options
> at the same time?
Is something like this is enough (or you'd like some printout with error
details)?
if (!proc_num && task_only)
usage_with_options(timechart_usage, options);
next prev parent reply other threads:[~2013-10-29 9:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 10:56 [PATCH 0/6] perf timechart improvements Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 1/6] perf timechart: always try to print at least 15 tasks Stanislav Fomichev
2013-10-29 7:50 ` Namhyung Kim
2013-10-29 9:24 ` Stanislav Fomichev
2013-11-01 6:06 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 2/6] perf timechart: use proc_num to implement --power-only Stanislav Fomichev
2013-10-29 8:03 ` Namhyung Kim
2013-10-29 9:28 ` Stanislav Fomichev
2013-11-01 6:07 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 3/6] perf timechart: add support for displaying only tasks related data Stanislav Fomichev
2013-10-29 8:10 ` Namhyung Kim
2013-10-29 9:33 ` Stanislav Fomichev [this message]
2013-11-01 6:10 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 4/6] perf timechart: group figures and add title with details Stanislav Fomichev
2013-10-29 8:15 ` Namhyung Kim
2013-10-29 9:35 ` Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 5/6] perf timechart: add support for -P and -T in timechart recording Stanislav Fomichev
2013-10-29 8:27 ` Namhyung Kim
2013-10-29 9:51 ` Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 6/6] perf timechart: add backtrace support Stanislav Fomichev
2013-10-29 8:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029093329.GC3406@stfomichev-desktop \
--to=stfomichev@yandex-team.ru \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox