Re: [v1 1/2] xen/p2m: Create identity mappings for PFNs beyound E820 and PCI BARs

Jan Beulich
2013-10-28T09:51:30Z

>>> On 26.10.13 at 00:08, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Oct 25, 2013 at 9:03 AM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> + unsigned long pfn, start, end, ok_pfns;
>> + char bus_addr[64];
>> + char *fmt;
>> +
>> + if (!pci_resource_len(pci_dev, i))
>> + continue;
>> +
>> + if (pci_resource_flags(pci_dev, i) == IORESOURCE_IO)
>
> You probably want:
>
> if (pci_resource_flags(pci_dev, i) & IORESOURCE_IO)
>
> here. And I don't understand what you're doing below, but my
> impression is you only care about MEM regions, not IO regions, so it
> seems like you might want to skip IO completely.

Yes indeed.

Jan