From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
sachin.kamat@linaro.org, Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate
Date: Tue, 29 Oct 2013 20:24:39 +0100 [thread overview]
Message-ID: <20131029202439.4740b297@skate> (raw)
In-Reply-To: <CAPcyv4iRawGxPwcPhyKCHG+2orVNmPktObR7_TSXwN+6tZ=qog@mail.gmail.com>
Dear Dan Williams,
On Tue, 29 Oct 2013 12:15:18 -0700, Dan Williams wrote:
> > I agree with Ezequiel, and I believe his patch is appropriate. The
> > registers for the XOR engines are indeed split in two areas, so it
> > makes sense to have this xor_base / xor_high_base split that reflects
> > the register mapping passed from the Device Tree, and use this split in
> > the macros used to access the registers.
> >
>
> Ah ok, so it's a bug if an implementation ever puts the second
> resource window at a non 0x200 offset.
Exactly.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-29 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:54 [PATCH 1/2] dma: mv_xor: Remove unneeded NULL address check Ezequiel Garcia
2013-10-28 22:54 ` [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate Ezequiel Garcia
2013-10-28 23:47 ` Dan Williams
2013-10-29 8:34 ` Ezequiel Garcia
2013-10-29 9:32 ` Thomas Petazzoni
2013-10-29 19:15 ` Dan Williams
2013-10-29 19:24 ` Thomas Petazzoni [this message]
2013-10-30 0:33 ` Ezequiel Garcia
2013-10-30 0:40 ` Dan Williams
2013-10-29 9:31 ` [PATCH 1/2] dma: mv_xor: Remove unneeded NULL address check Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029202439.4740b297@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox