From: Felipe Balbi <balbi@ti.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stern@rowland.harvard.edu>, <Paul.Zimmerman@synopsys.com>
Subject: Re: [PATCH v3 1/3] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget
Date: Wed, 30 Oct 2013 12:33:49 -0500 [thread overview]
Message-ID: <20131030173349.GO12193@gimli> (raw)
In-Reply-To: <1383152778-30739-2-git-send-email-david.a.cohen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
Hi,
On Wed, Oct 30, 2013 at 10:06:16AM -0700, David Cohen wrote:
> Due to USB controllers may have different restrictions, usb gadget layer
> needs to provide a generic way to inform gadget functions to complain
> with non-standard requirements.
>
> This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
> to inform when controller's epout requires buffer size to be aligned to
> MaxPacketSize.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
> include/linux/usb/gadget.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 942ef5e..9405d0f 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -540,6 +540,9 @@ struct usb_gadget {
> struct device dev;
> unsigned out_epnum;
> unsigned in_epnum;
> +
> + /* epout requires buffer size to be aligned to MaxPacketSize */
please document this on the kernel-doc comment above.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-30 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 17:06 [PATCH v3 0/3] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-10-30 17:06 ` [PATCH v3 1/3] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-10-30 17:31 ` Alan Stern
2013-10-30 17:36 ` Felipe Balbi
2013-10-30 17:33 ` Felipe Balbi [this message]
2013-10-30 17:06 ` [PATCH v3 2/3] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-10-30 17:35 ` Alan Stern
2013-11-04 19:02 ` David Cohen
2013-10-30 17:06 ` [PATCH v3 3/3] usb: dwc3: add quirk USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE to gadget driver David Cohen
2013-10-30 17:35 ` Felipe Balbi
2013-10-31 19:58 ` David Cohen
2013-10-31 21:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030173349.GO12193@gimli \
--to=balbi@ti.com \
--cc=Paul.Zimmerman@synopsys.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox