public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Frank Haverkamp <haver@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	utz.bacher@de.ibm.com, mmarek@suse.cz, rmallon@gmail.com,
	jsvogt@de.ibm.com, MIJUNG@de.ibm.com,
	cascardo@linux.vnet.ibm.com, michael@ibmra.de,
	Frank Haverkamp <haver@vnet.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)
Date: Wed, 30 Oct 2013 10:36:15 -0700	[thread overview]
Message-ID: <20131030173615.GC20147@kroah.com> (raw)
In-Reply-To: <1383125578-26202-2-git-send-email-haver@linux.vnet.ibm.com>

On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
> +/*
> + * Module initialization and PCIe setup. Card health monitoring and
> + * recovery functionality. Character device creation and deletion are
> + * controlled from here.
> + *
> + * Please use the new sysfs interfaces to enable the VFs after PF
> + * driver loading.
> + *
> + * Enable VFs:
> + *   sudo sh -c 'echo 15 > /sys/bus/pci/devices/0000\:1b\:00.0/sriov_numvfs'
> + * or
> + *   sudo sh -c 'echo 15 > /sys/class/genwqe/genwqe0_card/device/sriov_numvfs'
> + * Disable VFs:
> + *   Write a 0 into the same sysfs entries.
> + */

Put this documentation somewhere a user has a _chance_ of reading it.
Digging it out of code comments is not ok.  Why isn't this in the ABI
file for the sysfs files?

thanks,

greg k-h

  parent reply	other threads:[~2013-10-30 17:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  9:32 [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4) Frank Haverkamp
2013-10-30  9:32 ` Frank Haverkamp
2013-10-30 17:35   ` Greg KH
2013-10-30 20:38     ` Ryan Mallon
2013-11-04 16:19       ` Frank Haverkamp
2013-11-04 16:18     ` Frank Haverkamp
2013-10-30 17:36   ` Greg KH [this message]
2013-11-04 16:20     ` Frank Haverkamp
2013-10-30 17:37   ` Greg KH
2013-11-04 16:30     ` Frank Haverkamp
2013-10-30 17:39   ` Greg KH
2013-10-30 17:44   ` Greg KH
2013-11-04 16:41     ` Frank Haverkamp
2013-11-04 22:15       ` Greg KH
2013-11-05  7:16         ` Frank Haverkamp
2013-11-05 12:50           ` Greg KH
2013-10-31  3:49   ` Ryan Mallon
2013-11-04 16:44     ` Frank Haverkamp
2013-11-04 16:45     ` Frank Haverkamp
2013-11-12 13:50 ` Pavel Machek
2013-11-13 12:36   ` Frank Haverkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131030173615.GC20147@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=MIJUNG@de.ibm.com \
    --cc=arnd@arndb.de \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=cody@linux.vnet.ibm.com \
    --cc=haver@linux.vnet.ibm.com \
    --cc=haver@vnet.ibm.com \
    --cc=jsvogt@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@ibmra.de \
    --cc=mmarek@suse.cz \
    --cc=rmallon@gmail.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox