From: "Michael S. Tsirkin" <mst@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86: print microcode revision on PEBs errors
Date: Wed, 30 Oct 2013 21:31:50 +0200 [thread overview]
Message-ID: <20131030193150.GA7765@redhat.com> (raw)
On Sandy bridge CPUs with old microcode, PEBs
fails and suggests a microcode update.
Print out the required and the actual revision to
make it easier to figure out what's wrong.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
arch/x86/kernel/cpu/perf_event_intel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index f31a165..81f2789 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -2105,6 +2105,8 @@ static int intel_snb_pebs_broken(int cpu)
}
}
+ pr_info("PEBS checking: microcode 0x%x min legal 0x%x\n",
+ cpu_data(cpu).microcode, rev);
return (cpu_data(cpu).microcode < rev);
}
--
MST
next reply other threads:[~2013-10-30 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 19:31 Michael S. Tsirkin [this message]
2013-10-30 19:36 ` [PATCH] x86: print microcode revision on PEBs errors Joe Perches
2013-10-31 8:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030193150.GA7765@redhat.com \
--to=mst@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox