From: Cyrill Gorcunov <gorcunov@openvz.org>
To: linux-kernel@vger.kernel.org
Subject: [patch 0/6] Rework file::show_fdinfo method to use seq-files engine
Date: Wed, 30 Oct 2013 23:59:51 +0400 [thread overview]
Message-ID: <20131030195951.201688764@openvz.org> (raw)
Hi, in criu we intensively use additional information provided by
/proc/<pid>/fdinfo/<fd> particular to the object opened file
represents. The output is printed out by file_operations::show_fdinfo
method and the implementation of this method is pretty simple. Still
I think better would be to convert this method to seq_operations pointer
where all suppliers (epoll, eventfd and such) provide own seq-file
operations. While this makes code a little more complex this will
decrease the amount of kernel memory needed for output (because
we won't need to provide all information in one pass but by chunks).
Please take a look, thanks!
next reply other threads:[~2013-10-30 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 19:59 Cyrill Gorcunov [this message]
2013-10-30 19:59 ` [patch 1/6] procfs: Introduce sequential fdinfo engine Cyrill Gorcunov
2013-10-31 10:32 ` Alexey Dobriyan
2013-10-31 10:57 ` Cyrill Gorcunov
2013-10-31 12:12 ` Cyrill Gorcunov
2013-10-30 19:59 ` [patch 2/6] epoll: Use " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 3/6] eventfd: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 4/6] signalfd: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 5/6] fsnotify: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 6/6] procfs: Drop legacy show_fdinfo file operation Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030195951.201688764@openvz.org \
--to=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).