From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>,
acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features
Date: Thu, 31 Oct 2013 09:50:31 +0100 [thread overview]
Message-ID: <20131031085031.GB8992@gmail.com> (raw)
In-Reply-To: <20131029172903.GF7737@krava.brq.redhat.com>
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote:
> > feature_check needs to be invoked through call, and LDFLAGS may not be set
> > so quotes are needed.
>
> and the problem is also when there's more than one option in LDFLAGS
yeah.
> > Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving
> > me nuts with the upcoming timerfd feature detection.
> >
> > Signed-off-by: David Ahern <dsahern@gmail.com>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Jiri Olsa <jolsa@redhat.com>
>
> Reviewed-and-tested-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-31 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 16:43 [PATCH 1/2] tools/perf/build: Fix detection of non-core features David Ahern
2013-10-29 16:43 ` [PATCH 2/2] perf kvm: Disable live command if timerfd is not supported David Ahern
2013-10-29 17:29 ` Jiri Olsa
2013-11-05 5:00 ` David Ahern
2013-11-06 5:43 ` [tip:perf/core] " tip-bot for David Ahern
2013-10-29 17:29 ` [PATCH 1/2] tools/perf/build: Fix detection of non-core features Jiri Olsa
2013-10-31 8:50 ` Ingo Molnar [this message]
2013-11-05 4:59 ` David Ahern
2013-11-06 5:43 ` [tip:perf/core] " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031085031.GB8992@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox