Re: [PATCH 1/3] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8

Suravee Suthikulpanit
2013-11-08T14:23:11Z

On 11/02/2013 01:34 PM, Borislav Petkov wrote:
> On Thu, Oct 31, 2013 at 12:23:30PM +0100, Frederic Weisbecker wrote:
>> Ok we can keep that naming then, at least on the feature symbol. But
>> add a comment on it.
> Great, in the latest F16h BKDG the CPUID bit is called
> "DataBreakpointExtension". So BPEXT could mean anything :)
>
> So the comment is with the definition of the bit:
>
> +#define X86_FEATURE_BPEXT (6*32+26) /* data breakpoint extension */
>
> Oh well...
>
Sorry for late reply. And yes, the BDKG called it "Breakpoint Extension". Keeping the name consistent with the documentation might be best for now to avoid confusion.

So, would you like me to send in a new patch to add this comment?

Suravee