Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

Oleg Nesterov
2013-12-10T16:21:47Z

On 12/10, Frederic Weisbecker wrote:
>
> On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpanit@amd.com wrote:
> > @@ -525,14 +525,11 @@ int parse_events_add_breakpoint(struct list_head *list, int *idx,
> > if (parse_breakpoint_type(type, &attr))
> > return -EINVAL;
> >
> > - /*
> > - * We should find a nice way to override the access length
> > - * Provide some defaults for now
> > - */
> > - if (attr.bp_type == HW_BREAKPOINT_X)
> > - attr.bp_len = sizeof(long);
> > - else
> > - attr.bp_len = HW_BREAKPOINT_LEN_4;
> > + /* Provide some defaults if len is not specified */
> > + if (!len)
> > + len = attr.bp_type == HW_BREAKPOINT_X ? sizeof(long) :
> > + HW_BREAKPOINT_LEN_4;
>
> Why is LEN_4 affected in the type?

Hmm, what do you mean?

Oleg.