From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Oleg Nesterov <oleg@redhat.com>, Andrey Vagin <avagin@openvz.org>,
Al Viro <viro@zeniv.linux.org.uk>,
James Bottomley <jbottomley@parallels.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Matthew Helsley <matt.helsley@gmail.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/6] procfs: Introduce sequential fdinfo engine
Date: Thu, 31 Oct 2013 14:57:52 +0400 [thread overview]
Message-ID: <20131031105752.GB24809@moon> (raw)
In-Reply-To: <CACVxJT8vuh+Jm1LYhiQBLvi6TASpGgKm0CCqVS=g3QE+eHK7Wg@mail.gmail.com>
On Thu, Oct 31, 2013 at 01:32:13PM +0300, Alexey Dobriyan wrote:
> On Wed, Oct 30, 2013 at 10:59 PM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> > At moment the fdinfo operations (ie the output from /proc/$pid/fdinfo/$fd)
> > are generating output in one pass, which makes useless memory pressue
> > if the reader/user provides a buffer with a small size.
>
> cat(1) uses 64 KB buffer.
> The output doesn't exceed one page anyway.
Yes, good point. I probably need to update changelog (forgot that i'm using
single_open here). What if we meet a file with that big number of epoll
or say notifies assigned that the fdinfo won't fit a page? I didn't meet
such scenario yet, but I think it's possible?
next prev parent reply other threads:[~2013-10-31 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 19:59 [patch 0/6] Rework file::show_fdinfo method to use seq-files engine Cyrill Gorcunov
2013-10-30 19:59 ` [patch 1/6] procfs: Introduce sequential fdinfo engine Cyrill Gorcunov
2013-10-31 10:32 ` Alexey Dobriyan
2013-10-31 10:57 ` Cyrill Gorcunov [this message]
2013-10-31 12:12 ` Cyrill Gorcunov
2013-10-30 19:59 ` [patch 2/6] epoll: Use " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 3/6] eventfd: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 4/6] signalfd: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 5/6] fsnotify: " Cyrill Gorcunov
2013-10-30 19:59 ` [patch 6/6] procfs: Drop legacy show_fdinfo file operation Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031105752.GB24809@moon \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=bfields@fieldses.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=oleg@redhat.com \
--cc=tvrtko.ursulin@onelan.co.uk \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox