From: Vinod Koul <vinod.koul@intel.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 1/9] dma: pl330: Remove unnecessary amba_set_drvdata()
Date: Thu, 31 Oct 2013 19:55:12 +0530 [thread overview]
Message-ID: <20131031142512.GL18788@intel.com> (raw)
In-Reply-To: <27e289763bbcb7d10f84081543cfc3a4dc770398.1380793579.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]
On Thu, Oct 03, 2013 at 11:46:23AM +0200, Michal Simek wrote:
> Driver core clears the driver data to NULL after device_release
> or on probe failure, so just remove it from here.
>
> Driver core change:
> "device-core: Ensure drvdata = NULL when no driver is bound"
> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
Applied thanks
--
~Vinod
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/dma/pl330.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index a562d24..dfb2931 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -3029,8 +3029,6 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
>
> return 0;
> probe_err3:
> - amba_set_drvdata(adev, NULL);
> -
> /* Idle the DMAC */
> list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels,
> chan.device_node) {
> @@ -3064,7 +3062,6 @@ static int pl330_remove(struct amba_device *adev)
> of_dma_controller_free(adev->dev.of_node);
>
> dma_async_device_unregister(&pdmac->ddma);
> - amba_set_drvdata(adev, NULL);
>
> /* Idle the DMAC */
> list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels,
> --
> 1.8.2.3
>
--
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-31 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 9:46 [PATCH 1/9] dma: pl330: Remove unnecessary amba_set_drvdata() Michal Simek
2013-10-03 9:46 ` [PATCH 2/9] input: ambakmi: " Michal Simek
2013-10-03 9:46 ` [PATCH 3/9] ARM: etm: " Michal Simek
2013-10-03 9:46 ` [PATCH 4/9] mmc: mmci: " Michal Simek
2013-10-03 9:46 ` [PATCH 5/9] rtc: amba: " Michal Simek
2013-10-03 9:46 ` [PATCH 6/9] serial: " Michal Simek
2013-10-03 9:46 ` [PATCH 7/9] spi: pl022: " Michal Simek
2013-10-03 13:07 ` Mark Brown
2013-10-03 9:46 ` [PATCH 8/9] watchdog: sp805_wdt: " Michal Simek
2013-10-03 16:47 ` Guenter Roeck
2013-10-29 7:49 ` Wim Van Sebroeck
2013-10-03 9:46 ` [PATCH 9/9] video: amba-clcd: " Michal Simek
2013-10-09 8:44 ` Tomi Valkeinen
2013-10-31 14:25 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031142512.GL18788@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox