From: Tejun Heo <tj@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: WTF: driver-core-next contains recursive directory removal!
Date: Thu, 31 Oct 2013 11:29:50 -0400 [thread overview]
Message-ID: <20131031152950.GC11698@mtj.dyndns.org> (raw)
In-Reply-To: <87a9hqp78g.fsf@xmission.com>
Hello, Eric.
On Wed, Oct 30, 2013 at 06:19:27PM -0700, Eric W. Biederman wrote:
> The biggest and worst issue is the semantics are total unmaintable
> garbage and there has never been a single counter argument to that.
>
> Recursive delete is WRONG.
>
> Further there was no follow up converstion on the list about this trash
> to say you had tested it. Or anything else.
I think you're going over the line. You were cc'd on all patches and
all the counter points that I wrote in this thread are repetitions
from the previous threads. I don't remember you answering to any of
the counter points.
> Even the partial recursive delete we currently have has been responsible
> for broken users of sysfs so I don't see how adding additional checks is
> going to do anything but paper over real bugs in real uses of sysfs.
Can you please go into details of what kind of bugs would be
introduced by recursive removal? I'd really like to know and be happy
to fix any actual issues but you really aren't providing useful enough
information.
> Will you please remove that garbage from your tree.
Eric, chill.
--
tejun
next prev parent reply other threads:[~2013-10-31 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 22:38 WTF: driver-core-next contains recursive directory removal! Eric W. Biederman
2013-10-30 22:44 ` Greg Kroah-Hartman
2013-10-30 22:57 ` Eric W. Biederman
2013-10-31 15:24 ` Tejun Heo
2013-10-31 1:19 ` Eric W. Biederman
2013-10-31 15:29 ` Tejun Heo [this message]
2013-10-31 13:17 ` Bjorn Helgaas
2013-10-31 15:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031152950.GC11698@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).