From: Ben Myers <bpm@sgi.com>
To: "Geyslan Gregório Bem" <geyslan@gmail.com>,
"Eric Sandeen" <sandeen@sandeen.net>
Cc: Alex Elder <elder@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
XFS FILESYSTEM <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix possible NULL dereference
Date: Thu, 31 Oct 2013 10:55:03 -0500 [thread overview]
Message-ID: <20131031155503.GO1935@sgi.com> (raw)
In-Reply-To: <5271672C.7070101@sandeen.net>
Hey Geyslan,
On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
> On 10/23/13 3:34 PM, Ben Myers wrote:
>
> > xfs: fix possible NULL dereference in xlog_verify_iclog
> >
> > In xlog_verify_iclog a debug check of the incore log buffers prints an
> > error if icptr is null and then goes on to dereference the pointer
> > regardless. Convert this to an assert so that the intention is clear.
> > This was reported by Coverty.
> >
> > Reported-by: Geyslan G. Bem <geyslan@gmail.com>
> > Signed-off-by: Ben Myers <bpm@sgi.com>
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Applied this. Many thanks! ;)
-Ben
next prev parent reply other threads:[~2013-10-31 15:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 18:32 [PATCH] xfs: fix possible NULL dereference Geyslan G. Bem
[not found] ` <5265956F.4010700@sandeen.net>
2013-10-21 22:44 ` Dave Chinner
2013-10-21 23:12 ` Eric Sandeen
2013-10-21 23:18 ` Ben Myers
2013-10-21 23:56 ` Dave Chinner
2013-10-22 0:00 ` Eric Sandeen
2013-10-22 0:17 ` Dave Chinner
2013-10-22 10:12 ` Geyslan Gregório Bem
2013-10-22 20:39 ` Dave Chinner
2013-10-22 20:49 ` Eric Sandeen
2013-10-22 21:03 ` Dave Chinner
2013-10-22 21:19 ` Eric Sandeen
2013-10-22 22:02 ` Dave Chinner
2013-10-22 22:33 ` Ben Myers
2013-10-25 9:15 ` Dave Jones
2013-10-23 10:58 ` Geyslan Gregório Bem
2013-10-23 20:34 ` Ben Myers
2013-10-23 20:53 ` Geyslan Gregório Bem
2013-10-30 20:08 ` Eric Sandeen
2013-10-31 15:55 ` Ben Myers [this message]
2013-10-31 16:15 ` Geyslan Gregório Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031155503.GO1935@sgi.com \
--to=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=geyslan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox