* [patch] quota: info leak in quota_getquota()
@ 2013-11-01 10:21 Dan Carpenter
2013-11-04 13:16 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-01 10:21 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, kernel-janitors
The if_dqblk struct has a 4 byte hole at the end of the struct so
uninitialized stack information is leaked to user space.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/quota/quota.c b/fs/quota/quota.c
index dea86e8..2b363e2 100644
--- a/fs/quota/quota.c
+++ b/fs/quota/quota.c
@@ -117,6 +117,7 @@ static int quota_setinfo(struct super_block *sb, int type, void __user *addr)
static void copy_to_if_dqblk(struct if_dqblk *dst, struct fs_disk_quota *src)
{
+ memset(dst, 0, sizeof(*dst));
dst->dqb_bhardlimit = src->d_blk_hardlimit;
dst->dqb_bsoftlimit = src->d_blk_softlimit;
dst->dqb_curspace = src->d_bcount;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] quota: info leak in quota_getquota()
2013-11-01 10:21 [patch] quota: info leak in quota_getquota() Dan Carpenter
@ 2013-11-04 13:16 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-11-04 13:16 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jan Kara, linux-kernel, kernel-janitors
On Fri 01-11-13 13:21:54, Dan Carpenter wrote:
> The if_dqblk struct has a 4 byte hole at the end of the struct so
> uninitialized stack information is leaked to user space.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks. I've merged the patch into my tree.
Honza
>
> diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> index dea86e8..2b363e2 100644
> --- a/fs/quota/quota.c
> +++ b/fs/quota/quota.c
> @@ -117,6 +117,7 @@ static int quota_setinfo(struct super_block *sb, int type, void __user *addr)
>
> static void copy_to_if_dqblk(struct if_dqblk *dst, struct fs_disk_quota *src)
> {
> + memset(dst, 0, sizeof(*dst));
> dst->dqb_bhardlimit = src->d_blk_hardlimit;
> dst->dqb_bsoftlimit = src->d_blk_softlimit;
> dst->dqb_curspace = src->d_bcount;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-04 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-01 10:21 [patch] quota: info leak in quota_getquota() Dan Carpenter
2013-11-04 13:16 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox