From: Joerg Roedel <joro@8bytes.org>
To: Julian Stecklina <jsteckli@os.inf.tu-dresden.de>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits
Date: Fri, 1 Nov 2013 12:53:36 +0100 [thread overview]
Message-ID: <20131101115336.GH17455@8bytes.org> (raw)
In-Reply-To: <1381305832-2900-1-git-send-email-jsteckli@os.inf.tu-dresden.de>
On Wed, Oct 09, 2013 at 10:03:52AM +0200, Julian Stecklina wrote:
> The BUG_ON in drivers/iommu/intel-iommu.c:785 can be triggered from userspace via
> VFIO by calling the VFIO_IOMMU_MAP_DMA ioctl on a vfio device with any address
> beyond the addressing capabilities of the IOMMU. The problem is that the ioctl code
> calls iommu_iova_to_phys before it calls iommu_map. iommu_map handles the case that
> it gets addresses beyond the addressing capabilities of its IOMMU.
> intel_iommu_iova_to_phys does not.
>
> This patch fixes iommu_iova_to_phys to return NULL for addresses beyond what the
> IOMMU can handle. This in turn causes the ioctl call to fail in iommu_map and
> (correctly) return EFAULT to the user with a helpful warning message in the kernel
> log.
>
> Signed-off-by: Julian Stecklina <jsteckli@os.inf.tu-dresden.de>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2013-11-01 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 9:57 [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits Julian Stecklina
2013-08-28 15:44 ` Alex Williamson
2013-10-09 8:03 ` Julian Stecklina
2013-11-01 11:53 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101115336.GH17455@8bytes.org \
--to=joro@8bytes.org \
--cc=David.Woodhouse@intel.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jsteckli@os.inf.tu-dresden.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox