From: Wolfram Sang <wsa@the-dreams.de>
To: Tim Kryger <tim.kryger@linaro.org>
Cc: Christian Daudt <bcm@fixthebug.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode
Date: Fri, 1 Nov 2013 14:08:35 +0100 [thread overview]
Message-ID: <20131101130835.GC6734@katana> (raw)
In-Reply-To: <1381960909-1735-3-git-send-email-tim.kryger@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
> Add support for I2C high-speed mode (3.4 MHz).
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Mostly good as well:
> +enum hs_bus_speed_index {
> + BCM_SPD_3P4MHZ = 0,
> +};
I just realized that you should update both patches to add the supported
bus speeds to the binding documentation.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-01 13:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 22:01 [RESEND PATCH 0/4] Add-Broadcom-Kona-I2C-Support Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver Tim Kryger
2013-11-01 12:49 ` Wolfram Sang
2013-11-02 0:32 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode Tim Kryger
2013-11-01 13:08 ` Wolfram Sang [this message]
2013-11-07 19:57 ` Tim Kryger
2013-11-07 20:13 ` Wolfram Sang
2013-11-07 20:16 ` Tim Kryger
2013-10-16 22:01 ` [RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses Tim Kryger
2013-10-17 4:32 ` Christian Daudt
2013-10-17 12:14 ` Matt Porter
2013-10-16 22:01 ` [RESEND PATCH 4/4] ARM: dts: bcm28155-ap: Enable all the " Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101130835.GC6734@katana \
--to=wsa@the-dreams.de \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox