public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Алексей Крамаренко" <alexeyk13@yandex.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: FTDI custom VID/PID patch
Date: Fri, 1 Nov 2013 09:24:17 -0700	[thread overview]
Message-ID: <20131101162417.GA32287@kroah.com> (raw)
In-Reply-To: <5273AC0E.3010005@yandex.ru>

On Fri, Nov 01, 2013 at 05:26:38PM +0400, Алексей Крамаренко wrote:
> Hello Greg.
> 
> It's my first patch, sorry if something wrong.
> 
> Custom VID/PID for Z3X Box device, popular tool for cellphone flashing.

A few meta-comments.  Your patch had the tabs turned into spaces, the
lines were line-wrapped, and you put the Signed-off-by: at the bottom of
the patch, not up here in the changelog area.  I've fixed it up by hand,
but in the future, please work to fix your email client to not mutilate
patches.

thanks,

greg k-h

      reply	other threads:[~2013-11-01 16:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 13:26 FTDI custom VID/PID patch Алексей Крамаренко
2013-11-01 16:24 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131101162417.GA32287@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexeyk13@yandex.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox