From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991Ab3KCGbL (ORCPT ); Sun, 3 Nov 2013 01:31:11 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:21313 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250Ab3KCGbI (ORCPT ); Sun, 3 Nov 2013 01:31:08 -0500 Date: Sun, 3 Nov 2013 09:30:49 +0300 From: Dan Carpenter To: Aldo Iljazi Cc: marek.belisko@gmail.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: ft1000: fixed coding style issues Message-ID: <20131103063049.GI26669@mwanda> References: <1383426232-24686-1-git-send-email-mail@aldo.io> <20131102211820.GA24821@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131102211820.GA24821@linux> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: > Aldo Iljazi wrote: > > > Fixed a few coding style issues that checkpatch reported. > > > > Specifically: > > > > 1. line over 80 characters issue on the lines 9 and 10. > > 2. space prohibited before open square bracket '[' issue on the lines > > 31. > > 3. inserted space after comma on lines 32 to 156. > > > > Signed-off-by: Aldo Iljazi This file is easy to review so you may as well fix all the issues. Clean up the license block so it's in the normal format. Put the commas at the end of the line instead of the beginning. regards, dan carpenter