From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750863Ab3KDFFQ (ORCPT ); Mon, 4 Nov 2013 00:05:16 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:57866 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717Ab3KDFFN (ORCPT ); Mon, 4 Nov 2013 00:05:13 -0500 Date: Sun, 3 Nov 2013 21:04:55 -0800 From: Olof Johansson To: Grant Likely Cc: devicetree@vger.kernel.org, Linux Kernel Mailing List , Kevin Hilman , Benjamin Herrenschmidt Subject: Re: [RFC 4/9] of/irq: Refactor interrupt-map parsing Message-ID: <20131104050455.GA3651@quad.lixom.net> References: <1381869563-16083-1-git-send-email-grant.likely@linaro.org> <1381869563-16083-5-git-send-email-grant.likely@linaro.org> <20131031185714.GA12646@quad.lixom.net> <20131101175317.A812AC40868@trevor.secretlab.ca> <20131101185401.B298FC40868@trevor.secretlab.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131101185401.B298FC40868@trevor.secretlab.ca> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2013 at 11:54:01AM -0700, Grant Likely wrote: > On Fri, 01 Nov 2013 10:53:17 -0700, Grant Likely wrote: > > On Thu, 31 Oct 2013 11:57:14 -0700, Olof Johansson wrote: > > > On Wed, Oct 30, 2013 at 02:25:21PM -0700, Grant Likely wrote: > > > > (Sorry for HTML mail) > > > > > > > > Can you put #define DEBUG at the top of drivers/of/irq.c and send me the > > > > log output from before and after the commit? > > > > > > Here you go, quite verbose log below. > > > > > > Looks like we're tripping the "no reg passed in" checks, not sure if related. > > > > I think I've found the bug. See if this helps... > > That one was broken. Try this instead. > > From bcbffc3d16f49451ef505dc021480aa061465a15 Mon Sep 17 00:00:00 2001 > From: Grant Likely > Date: Fri, 1 Nov 2013 10:50:50 -0700 > Subject: [PATCH] of: Fixup interrupt parsing failure. > > Signed-off-by: Grant Likely Well, it boots. That's an improvement. :) It is again going for the precalculated delay loop. I'm not sure why the code path diverged before, especially given the below irq request fail for MCT. I do see a bunch of new printk errors that I didn't use to though: [ 0.000000] genirq: Flags mismatch irq 160. 00015200 (mct_comp_irq) vs. 00014a00 (mct_tick0) [ 0.040401] genirq: Flags mismatch irq 160. 00014a00 (mct_tick1) vs. 00014a00 (mct_tick0) [ 0.040405] exynos-mct: cannot register IRQ 160 So I don't think we're home safe yet. I need to spend some time this week actually debugging this... Good thing the merge window is delayed. -Olof