From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aldo Iljazi <mail@aldo.io>
Cc: marek.belisko@gmail.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ft1000: fixed a few styling issues
Date: Mon, 4 Nov 2013 15:29:35 +0300 [thread overview]
Message-ID: <20131104122935.GN26669@mwanda> (raw)
In-Reply-To: <1383567322-22879-1-git-send-email-mail@aldo.io>
On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote:
> Fixed the following styling issues:
>
> Line 30:
> Removed space before open square bracket '['
>
> Lines 31 to 155:
> Moved the commas that were in the start of the lines, to the end of the lines.
> Inserted spaces after the commas.
> Inserted a one tab indentation to each line.
>
> Signed-off-by: Aldo Iljazi <mail@aldo.io>
Looks nice. Thank you.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2013-11-04 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 12:15 [PATCH] Staging: ft1000: fixed a few styling issues Aldo Iljazi
2013-11-04 12:29 ` Dan Carpenter [this message]
2013-11-04 12:31 ` Aldo Iljazi
2013-11-04 12:32 ` Ondrej Zary
2013-11-04 12:58 ` Dan Carpenter
2013-11-12 0:24 ` Greg KH
2013-11-12 0:28 ` [PATCH] Staging: ft1000: boot.h: " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-11-03 14:20 [PATCH] Staging: ft1000: " Aldo Iljazi
2013-11-03 23:10 ` Dan Carpenter
2013-11-04 8:17 ` Aldo Iljazi
2013-11-04 8:24 ` Dan Carpenter
2013-11-04 8:40 ` Aldo Iljazi
2013-11-04 8:45 ` Dan Carpenter
2013-11-04 8:46 ` Aldo Iljazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104122935.GN26669@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aldo.io \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox