From: Sebastian Andrzej Siewior <bigeasy@breakpoint.cc>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
jic23@kernel.org, lars@metafoo.de, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] debugobject: add support for kref
Date: Mon, 4 Nov 2013 17:15:48 +0100 [thread overview]
Message-ID: <20131104161548.GA26097@breakpoint.cc> (raw)
In-Reply-To: <20131103193308.GA20998@linutronix.de>
On 03.11.13, Sebastian Andrzej Siewior wrote:
> v1…v2:
> - not an RFC anymore
> - addressed tglx review:
> - use debug_obj_descr with state active
> - use debug_object_active_state() to check for active object instead the
> other hack I had.
> - added debug_object_free() in a way that does not interfere with the
> NSA sniffer API so it does not get removed from the patch by accident.
now I just run into output like
|ODEBUG: free active (active state 0) object type: kref hint: gserial_alloc_line+0x90/0x194 [u_serial]
and yes I added a hint for that which points to where the kref got it
kref_init() call from. Now I am not sure if this a false positive
(we did kref_init() never used it so the whole struct was removed) or if
it really found something.
And while I hit this, I noticed that I really need a fixup function or
else debugobject will loop forever in __debug_check_no_obj_freed().
Sebastian
next prev parent reply other threads:[~2013-11-04 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 10:09 [RFC PATCH] debugobject: add support for kref Sebastian Andrzej Siewior
2013-10-24 14:48 ` Thomas Gleixner
2013-11-03 19:33 ` [PATCH v2] " Sebastian Andrzej Siewior
2013-11-04 16:15 ` Sebastian Andrzej Siewior [this message]
2013-12-11 6:45 ` Greg KH
2013-12-11 9:21 ` Thomas Gleixner
2013-12-11 9:30 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104161548.GA26097@breakpoint.cc \
--to=bigeasy@breakpoint.cc \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox