From: Mel Gorman <mgorman@suse.de>
To: Don Morris <don.morris@hp.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>
Subject: Re: BUG: soft lockup - CPU#8 stuck for 22s!
Date: Mon, 4 Nov 2013 17:04:13 +0000 [thread overview]
Message-ID: <20131104170413.GA25764@suse.de> (raw)
In-Reply-To: <5266B5F2.5070102@hp.com>
On Tue, Oct 22, 2013 at 01:29:22PM -0400, Don Morris wrote:
> Greetings, all.
>
> Just wanted to drop this out there to see if it rang any bells.
> I've been getting a soft lockup (numad thread stuck on a cpu
> while attempting to attach a task to a cgroup) for a while now,
> but I thought it was only happening when I applied Mel Gorman's
> set of AutoNUMA patches.
This maybe?
---8<---
mm: memcontrol: Release css_set_lock when aborting an OOM scan
css_task_iter_start acquires the css_set_lock and it must be released with
a call to css_task_iter_end. Commmit 9cbb78bb (mm, memcg: introduce own
oom handler to iterate only over its own threads) introduced a loop that
was not guaranteed to call css_task_iter_end.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Mel Gorman <mgorman@suse.de>
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 5ef8929..941f67d 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1795,6 +1795,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
mem_cgroup_iter_break(memcg, iter);
if (chosen)
put_task_struct(chosen);
+ css_task_iter_end(&it);
return;
case OOM_SCAN_OK:
break;
next prev parent reply other threads:[~2013-11-04 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 17:29 BUG: soft lockup - CPU#8 stuck for 22s! Don Morris
2013-11-04 15:13 ` Mel Gorman
2013-11-04 17:04 ` Mel Gorman [this message]
2013-11-04 17:33 ` Don Morris
2013-11-07 0:30 ` David Rientjes
2013-11-07 9:06 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104170413.GA25764@suse.de \
--to=mgorman@suse.de \
--cc=don.morris@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox