From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Chen Gong <gong.chen@linux.intel.com>
Subject: Re: [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface
Date: Wed, 6 Nov 2013 15:17:41 +0100 [thread overview]
Message-ID: <20131106141740.GA16072@x1.alien8.de> (raw)
In-Reply-To: <527940181131657a6@agluck-desk.sc.intel.com>
On Tue, Nov 05, 2013 at 10:59:36AM -0800, Luck, Tony wrote:
> -static int __einj_error_inject(u32 type, u64 param1, u64 param2)
> +static int __einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2,
> + u64 param3, u64 param4)
I wonder if, at some point in the future - not now, necessarily, it'll
be prudent to add an error injection struct descriptor which contains
all those param* thingies and some of them could even be defined as a
union in it in order to make the whole code more readable. Like the
'address' variable, for example, which is valid for multiple error
types...
Just an idea though, so let me throw it out in the open.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2013-11-06 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 18:59 [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface Luck, Tony
2013-11-06 6:32 ` Naveen N. Rao
2013-11-06 14:17 ` Borislav Petkov [this message]
2013-11-06 21:26 ` Tony Luck
2013-11-06 21:30 ` [PATCHv2] " Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106141740.GA16072@x1.alien8.de \
--to=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox