From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Benson Leung <bleung@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED
Date: Wed, 6 Nov 2013 12:45:23 -0800 [thread overview]
Message-ID: <20131106204523.GA19041@kroah.com> (raw)
In-Reply-To: <1383769641-22910-1-git-send-email-jwerner@chromium.org>
On Wed, Nov 06, 2013 at 12:27:21PM -0800, Julius Werner wrote:
> This patch adds a check for USB_STATE_NOTATTACHED to the
> hub_port_warm_reset_required() workaround for ports that end up in
> Compliance Mode in hub_events() when trying to decide which reset
> function to use. Trying to call usb_reset_device() with a NOTATTACHED
> device will just fail and leave the port broken.
Who makes those calls, drivers? Any specific ones that you know need to
be fixed?
> Also bumped the messages about this kind of reset failure from dev_dbg()
> to dev_warn() to make it easier to notice, since calling that function
> with a NOTATTACHED device would almost always be a bug
But what can a user do if those messages show up?
thanks,
greg k-h
next prev parent reply other threads:[~2013-11-06 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:27 [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED Julius Werner
2013-11-06 20:45 ` Greg Kroah-Hartman [this message]
2013-11-06 21:52 ` Alan Stern
2013-11-06 22:41 ` Julius Werner
2013-11-07 15:32 ` Alan Stern
2013-11-07 18:51 ` Julius Werner
2013-11-07 18:59 ` [PATCH v2] " Julius Werner
2013-11-08 16:58 ` Alan Stern
2013-11-14 23:30 ` [PATCH] " Sarah Sharp
2013-11-18 19:08 ` Julius Werner
2013-11-19 14:53 ` Cortes, Alexis
2013-12-05 0:04 ` Sarah Sharp
2013-12-05 16:50 ` Cortes, Alexis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106204523.GA19041@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bleung@chromium.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox