Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

Greg KH
2013-11-08T02:00:51Z

On Thu, Nov 07, 2013 at 09:06:26AM -0800, Luigi Semenzato wrote:
> If I may add my usual 2c (and some news):
>
> zram is used by default on all Chrome OS devices. I can't say how
> many devices, but it's not a small number, google it, and it's an
> important market, low-end laptops for education and the less affluent.
> It has been available experimentally for well over a year.
>
> Android 4.4 KitKat is also using zram, to better support devices with
> less than 1 MB RAM. (That's the news.)
>
> When comparing the relative advantages of the two subsystems (zram and
> zswap), let's not forget that considerable effort goes into in tuning
> and bug fixing for specific use cases---possibly even more than the
> initial development effort. Zram has not just been sitting around in
> drivers/staging, it's in serious use.
>
> If we were to judge systems based merely on theoretical technical
> merit, then we should consider switching en masse to FreeBSD. (I said
> we should *consider* :).
>
> I am very familiar with the limitations of zram, but it works well and
> I think it would be wise to keep supporting it. Besides, it's small
> and AFAICT it interfaces cleanly with the rest of the system, so I
> don't see what the big deal is.

Then please help with getting it merged properly, and out of staging.

thanks,

greg k-h