Re: [PATCH 2/4] perf record: Remove advance_output function

[Ingo Molnar <mingo@kernel.org>]

* David Ahern <dsahern@gmail.com> wrote:

> 1 line function with only 1 user; might as well embed directly.
> 
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung.kim@lge.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Stephane Eranian <eranian@google.com>
> ---
>  tools/perf/builtin-record.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 2932069ad7a8..19c4db6bdd6f 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -77,11 +77,6 @@ struct perf_record {
>  	off_t			post_processing_offset;
>  };
>  
> -static void advance_output(struct perf_record *rec, size_t size)
> -{
> -	rec->bytes_written += size;
> -}
> -
>  static int write_output(struct perf_record *rec, void *buf, size_t size)
>  {
>  	struct perf_data_file *file = &rec->file;
> @@ -461,7 +456,7 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv)
>  				pr_err("Couldn't record tracing data.\n");
>  				goto out_delete_session;
>  			}
> -			advance_output(rec, err);
> +			rec->bytes_written += err;
>  		}
>  	}

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo