From: Ingo Molnar <mingo@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
jolsa@redhat.com, "Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH 0/4] perf record: Cleanups and mmap-based output
Date: Thu, 7 Nov 2013 09:06:14 +0100 [thread overview]
Message-ID: <20131107080614.GF31926@gmail.com> (raw)
In-Reply-To: <1383763297-27066-1-git-send-email-dsahern@gmail.com>
* David Ahern <dsahern@gmail.com> wrote:
> I know Jiri is working on cleanups of the output file, but had this
> sitting around for a couple of weeks now. Might as well push it out
> for the next baseline. The cleanups of perf-record can be taken
> independently.
>
> Ingo: I took a look at leveraging the copy_user_nocache and was not able
> to get it to work. I won't have time to come back to it for a while.
> Given that the mmap output already improves perf-trace a lot I would
> like to get the option into 3.13 and come back to the optimization
> later.
That's OK - your feature is already a big step forward!
1-3 look good to me and 4/4 needs some minor cleanups (see my review
mail).
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-07 8:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 18:41 [PATCH 0/4] perf record: Cleanups and mmap-based output David Ahern
2013-11-06 18:41 ` [PATCH 1/4] perf record: Refactor feature handling into a separate function David Ahern
2013-11-07 8:03 ` Ingo Molnar
2013-11-07 15:30 ` [tip:perf/core] " tip-bot for David Ahern
2013-11-06 18:41 ` [PATCH 2/4] perf record: Remove advance_output function David Ahern
2013-11-07 8:04 ` Ingo Molnar
2013-11-07 15:31 ` [tip:perf/core] " tip-bot for David Ahern
2013-11-06 18:41 ` [PATCH 3/4] perf record: Remove post_processing_offset variable David Ahern
2013-11-07 8:04 ` Ingo Molnar
2013-11-07 15:31 ` [tip:perf/core] " tip-bot for David Ahern
2013-11-06 18:41 ` [PATCH 4/4] perf record: mmap output file - v3 David Ahern
2013-11-07 8:03 ` Ingo Molnar
2013-11-07 16:06 ` David Ahern
2013-11-11 11:53 ` Ingo Molnar
2013-11-07 8:06 ` Ingo Molnar [this message]
2013-11-07 9:38 ` [PATCH 0/4] perf record: Cleanups and mmap-based output Jiri Olsa
2013-11-07 13:21 ` Jiri Olsa
2013-11-07 15:59 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107080614.GF31926@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox