From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622Ab3KGLlm (ORCPT ); Thu, 7 Nov 2013 06:41:42 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28433 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783Ab3KGLll (ORCPT ); Thu, 7 Nov 2013 06:41:41 -0500 Date: Thu, 7 Nov 2013 14:38:49 +0300 From: Dan Carpenter To: Gu Zheng Cc: jfrederich@gmail.com, dsd@laptop.org, jon.nettleton@gmail.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, Tomi Valkeinen , Jean-Christophe PLAGNIOL-VILLARD , linux-kernel Subject: Re: [RESEND PATCH 2/2] staging/olpc_docn: reorder the lock sequence to avoid potential dead lock Message-ID: <20131107113849.GM20521@mwanda> References: <5278C1DC.9000609@cn.fujitsu.com> <20131105110242.GQ26669@mwanda> <527999DC.1090206@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <527999DC.1090206@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2013 at 09:22:36AM +0800, Gu Zheng wrote: > Hi Dan, > On 11/05/2013 07:02 PM, Dan Carpenter wrote: > > > On Tue, Nov 05, 2013 at 06:01:00PM +0800, Gu Zheng wrote: > >> The lock sequence of dcon_blank_fb(fb_info->lock ---> console_lock) is against > >> with the one of console_callback(console_lock ---> fb_info->lock), it'll > >> lead to a potential dead lock, so reorder the lock sequence of dcon_blank_fb > >> to avoid the potential dead lock. > >> > >> Signed-off-by: Gu Zheng > > > > Relax, Greg isn't taking new patches for another three weeks because the > > merge window is open. > > Got it, I just want to gain some comments about this patch. > If no one complains that means it is approved. :) regards, dan carpenter